This repository has been archived by the owner on Jun 29, 2018. It is now read-only.
[t1147] added safety harness for youtube init #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // A global callback for youtube... that makes me angry | ||
| var onYouTubePlayerAPIReady = function() { | ||
| global.onYouTubePlayerAPIReady = function() { | ||
|
|
There was a problem hiding this comment.
Two things.
-
I think this should be PopcornYT
-
You need to declare this so we don't leak into global. Maybe do it up above where you declare oldYT
1. Added some documentation in code 2. Fixed up leaky globals 3. Adjusted older ready variables to not be on ready function
| } | ||
| }; | ||
|
|
||
| // Store a reference to the old youtubePlayerReady function if there was one |
There was a problem hiding this comment.
Move this down with your if (global.YT) check below, since they are somewhat paired.
|
Is this still valid? |
|
Staged on master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.