Skip to content
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.

Seq wrapper #270

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Seq wrapper #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb5d46a
seq2
ScottDowne Jan 9, 2013
56bc05a
[#1254] Youtube player using the wrapper.
ScottDowne Jan 14, 2013
27ad5c7
Merge branch 'seq2' into seq-wrapper
ScottDowne Jan 15, 2013
788b881
seq-wrapper
ScottDowne Jan 15, 2013
8f05f2a
testing sequencer.
ScottDowne Jan 21, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/player/popcorn.player.js
View file
Open in desktop
Expand Up @@ -366,6 +366,7 @@
// See if we can use a wrapper directly, if not, try players.
for ( j = 0; j < wrappers.length; j++ ) {
mediaWrapper = Popcorn[ wrappers[ j ] ];
srci = srci.replace( /^https\:\/\/soundcloud\.com/, "http://soundcloud.com" );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapper-specific handling like this should be done in the wrapper, eg. https://github.com/mozilla/popcorn-js/blob/master/wrappers/soundcloud/popcorn.HTMLSoundCloudAudioElement.js#L524-L528

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally just hacking up something for debugging purposes.

Not in review yet :)

Not yet sure how to solve it, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to solve this particular part or the whole thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soundcloud seems to be breaking on https. not sure why. Have not had time to dig into it or move this hack to a better spot yet.

if ( mediaWrapper && mediaWrapper._canPlaySrc( srci ) === "probably" ) {
media = mediaWrapper( node );
popcorn = Popcorn( media, options );
Expand Down