Skip to content
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.

[#1040] Add height and width param to options, and tests. #48

Merged
merged 3 commits into from May 3, 2012

Conversation

ScottDowne
Copy link
Contributor

No description provided.

newdiv.style.width = options.width || "100%";

// height is a little more complicated than width.
if ( options.height ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra vertical space after each if/elseif is not needed. Please remove in all three blocks below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I am following https://webmademovies.lighthouseapp.com/projects/63272/styleguide best I can. Been doing it this way for a while now. Doesn't mean it is right, though.

But, I can see multiple interpretations.

Like:

// Good

if ( condition ) {

doSomething();

}

while ( condition ) {

iterating++;

}

for ( var i = 0; i < 100; i++ ) {

someIterativeFn();

}

and:

// Good
if ( true ) {
return;
}

if ( true ) {
blah();
}

if ( true ) {

foo();

} else {

bar();

}

dseif added a commit that referenced this pull request May 3, 2012
[#1040] google maps height still not working in all cases
@dseif dseif merged commit 63d8b0d into mozilla:master May 3, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants