Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

Remove references to Test Pilot? #302

Open
pdehaan opened this issue Jan 23, 2019 · 1 comment
Open

Remove references to Test Pilot? #302

pdehaan opened this issue Jan 23, 2019 · 1 comment

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Jan 23, 2019

Test Pilot has been retired (). Not sure which references in this repo need to be updated/changed/removed:

$ git rev-parse --short HEAD # 6c2730e

$ git grep -i pilot

.circleci/deploy_addon.sh:# Adapted from clouserw's script for publishing add-ons to Test Pilot from
.circleci/deploy_addon.sh:ADDON_ID="shopping-testpilot@mozilla.org"
.circleci/deploy_addon.sh:          "update_link": "https://testpilot.firefox.com/files/$ADDON_ID/latest",
README.md:  <dt><code>extensions.shopping-testpilot@mozilla.org.extractionAllowlist</code></dt>
README.md:  <dt><code>extensions.shopping-testpilot@mozilla.org.priceCheckInterval</code></dt>
README.md:  <dt><code>extensions.shopping-testpilot@mozilla.org.priceCheckTimeoutInterval</code></dt>
README.md:  <dt><code>extensions.shopping-testpilot@mozilla.org.iframeTimeout</code></dt>
README.md:  <dt><code>extensions.shopping-testpilot@mozilla.org.alertPercentThreshold</code></dt>
README.md:  <dt><code>extensions.shopping-testpilot@mozilla.org.alertAbsoluteThreshold</code></dt>
README.md:Price Wise bumps the major version number for every release, similar to Firefox. Releases are created by tagging a commit that bumps the version number and pushing that tag to the repo. This triggers CircleCI automation that packages, tests, signs and uploads the new version to the Test Pilot S3 bucket.
README.md:This hold job is intended to provide developers and QA an opportunity for final testing and review of the extension in release channels before uploading. When QA is satisfied, a developer with push access must manually trigger the upload to Test Pilot via the CircleCI dashboard by clicking the hold job and approving the build.
README.md:Once the upload is complete, the new version should be available immediately at https://testpilot.firefox.com/files/shopping-testpilot@mozilla.org/latest.
docs/METRICS.md:  "shopping-testpilot@mozilla.org",
docs/METRICS.md:    "source": "testpilot"
src/browser_action/index.jsx:  if (await browser.customizableUI.isWidgetInOverflow('shopping-testpilot_mozilla_org-browser-action')) {
src/config.js: * subtree extensions.shopping-testpilot@mozilla.org.prefName.
src/config.js:  supportUrl: new StringValue('https://support.mozilla.org/kb/new-test-pilot-experiments'),
src/experiment_apis/shoppingPrefs/api.js:    const branch = Services.prefs.getBranch('extensions.shopping-testpilot@mozilla.org.');
src/manifest.json:      "id": "shopping-testpilot@mozilla.org",
web-ext-config.js:      'extensions.shopping-testpilot@mozilla.org.priceCheckInterval=30000',
web-ext-config.js:      'extensions.shopping-testpilot@mozilla.org.priceCheckTimeoutInterval=30000',
web-ext-config.js:      'extensions.shopping-testpilot@mozilla.org.iframeTimeout=10000',

It looks like we still may be using the TestPilot CI pipeline which sends things to an S3 bucket, which we may not need if this moves to AMO.

@Osmose
Copy link
Contributor

Osmose commented Jan 24, 2019

We're in the middle of moving over the AMO. The rough verdict on each of these occurrances IMO:

  • Once the migration to AMO is complete the deploy script that uploads to S3 will be removed along with the documentation mentions.
  • The preference names are all due to the add-on ID, and I'm a bit hesitant to change that now that we have active users. I think keeping them for now won't be harmful as a typical user wouldn't see the add-on ID or mess with the prefs.
  • The metrics docs only mention it in an example ping, not sure that needs to be changed.
  • The SUMO page does need to be updated, as the current URL is 404ing.

Osmose pushed a commit to Osmose/price-wise that referenced this issue Jan 25, 2019
Osmose pushed a commit to Osmose/price-wise that referenced this issue Jan 25, 2019
Osmose added a commit that referenced this issue Jan 28, 2019
#302: Remove links to deleted SUMO page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants