Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download buttons should be inline-block instead of block level? #486

Closed
alexgibson opened this issue Sep 16, 2019 · 4 comments
Closed

Download buttons should be inline-block instead of block level? #486

alexgibson opened this issue Sep 16, 2019 · 4 comments
Labels
Bug 🪲 Something isn't working Good First Bug Folks wanting to contribute and learning protocol can take on easier bugs as leads into the system. Size: XS Est. half-day of work

Comments

@alexgibson
Copy link
Member

Description

Download button containers are block level, meaning they take up 100% of their parent's container width. They should probably be inline-block?

Steps to reproduce

  1. Visit https://protocol.mozilla.org/patterns/molecules/download-button.html

Expected result

image

Actual result

image

Environment

Any browser.
@alexgibson alexgibson added the Bug 🪲 Something isn't working label Sep 16, 2019
@amychurchwell amychurchwell added Good First Bug Folks wanting to contribute and learning protocol can take on easier bugs as leads into the system. Size: XS Est. half-day of work labels Sep 20, 2019
@RyanWils
Copy link

RyanWils commented Oct 3, 2019

Hi I am fairly new to the open source community and this looks like a good bug to start with.
If it is okay with you, I would like to work on this bug.

@thisisabhinay
Copy link
Contributor

@RyanWils What's the status update? If you are not working on it then I would like to continue working on this one.

@RyanWils
Copy link

Feel free to work on it, I am having issues with the launching of the local instance.
I have opened a ticket about my issue, but they have not got back to me yet.
Issue - #501

thisisabhinay pushed a commit to thisisabhinay/protocol that referenced this issue Oct 16, 2019
Updates '.mzp-c-button-download-container' class
534b4d5 
- Changes '.mzp-c-button-download-container' display property to 'inline-block' from 'block'
- Fix mozilla#486
@thisisabhinay thisisabhinay mentioned this issue Oct 16, 2019
Closed
2 tasks
This was referenced Nov 27, 2019
Closed
Closed
@tikhsuP
Copy link
Contributor

tikhsuP commented Dec 7, 2019

@alexgibson @amychurchwell, my above PR generates this result :
Screenshot (262)

Do I need to change the Download Button (Secondary) to this
Screenshot (263) as well?

craigcook pushed a commit that referenced this issue May 8, 2020
@craigcook
[fix #486] Set '.mzp-c-button-download-container' to inline-block
65627ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🪲 Something isn't working Good First Bug Folks wanting to contribute and learning protocol can take on easier bugs as leads into the system. Size: XS Est. half-day of work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexgibson @amychurchwell @tikhsuP @RyanWils @thisisabhinay