-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component Change Request: use AAA contrast standards on Error notification bar #848
Comments
@reemhamz Thanks for your thoughts! I agree the font-size increase is more effective than the font color adjustment alone. I initially thought large & bolded would be best, but we seem to reserve bold styling for clickable things in the notification bars. The success notification bar is in all the WNPs. We should check if a font size increase there is off-putting before changing all the component font-sizes. I think it would be acceptable for the error notification alone to have larger font size (similar to how the clickable notification is bolded, it's part of the specific intention of that type of notification to be a bit more in-your-face). Changing the font color to black across all notification component styles should be OK in any case. |
|
## Description Related to issue #848, @maureenlholland and I spoke about how either increasing the `font-size` or changing the `color` of the text in the notification bar would be slightly better for visual accessibility. In the issue, I tested changes by: - Increasing `font-size` to `16px`, and - Changing `color` to `#000000` Both seemed to be viable options for visual clarify on the component. However, a change in one of the notification bars would usually mean a change to the rest for sake of consistency. The increase in `font-size`, most notably on the success notification bar in the WNPs, seemed to jumble the order of the page's content hierarchy by just a bit. So instead of going with increasing `font-size` we opted to select to just change `color` to `#000000` for all notification bars. Not a significant change in itself, but still positively noticeable. Describe what this change does. - [ ] I have documented this change in the design system. - [x] I have recorded this change in `CHANGELOG.md`. ### Issue #848 ### Testing http://localhost:3000/components/detail/notification-bar--error (and the rest of the variants)
PR merged, but leaving this issue open for further discussion (feel free to close and open a new issue specifically for standardizing error colors across Protocol components) From Craig's comment on the PR:
|
Made a quick test via devtools and checked out the color contrast using webAIM: (note: color used was It has the highest contrast ratio from all the reds we tested and imo wouldn't be a bad color to use for the rest of Protocol. However, looking at it from a color psychology POV, does darker red add more stress opposed to lighter reds? Would love to head what @ehot has to say. |
cc: @maureenlholland @craigcook @ehot for visibility here. |
Thanks for the ping @reemhamz Going to preface this by saying I don't have a strong opinion beyond, let's make it AAA level contrast, but aesthetically I feel this dark red + white text combination is a tough fit with our other, more vibrant notification background colors. That said, the error notification color combo (while passing AAA standards) might not be a great fit for small text form errors Maybe it's possible to have a primary error style (default) and secondary error style (when you need that extra bit of contrast)? I defer to you and Elise and Craig for the standardization decision. |
I think we can try a shade lighter red, as well as changing the text color to black on the form errors. |
Will be attempting |
Please describe the change you wish to see
Aim for AAA WCAG color contrast standards on Errors notification bars
Please describe why these changes need to be made
The current Error notification styles pass normal AA contrast checks but fail AAA normal text check
![current-contrast](https://user-images.githubusercontent.com/19650432/216604919-5fc97f36-1202-43b9-97cf-94fa51f63856.png)
In the case of Error notifications, it feels like we should go beyond normal requirements and make the text as easy to read as possible. Errors are already frustrating and it would compound user frustration to struggle to read the error description.
![error](https://user-images.githubusercontent.com/19650432/216605048-9cd4f771-763c-42a0-8e70-e5f225baf5f9.png)
Please provide any designs or prototypes of the proposed changes
Enforcing large/bolded text might be the most effective solution.
Please describe where this component is currently in use
Screenshot above is from Newsletter error (locally forcing errors from the views.py file: http://localhost:8000/en-US/newsletter/confirm/thanks/?error=2)
Please describe what this component should do in the following conditions
I don't think it needs any changes to responsive viewport behaviour or dark/light theme
Is the development of this component a blocking dependency for other work? Please explain if so
Not blocking
The text was updated successfully, but these errors were encountered: