Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix card molecule icon alignment for RTL (Fixes #203) #220

Merged
merged 1 commit into from Nov 14, 2018
Merged

Fix card molecule icon alignment for RTL (Fixes #203) #220

merged 1 commit into from Nov 14, 2018

Conversation

alexgibson
Copy link
Member

No description provided.

@alexgibson alexgibson added the Bug 🪲 Something isn't working label Sep 7, 2018
@alexgibson alexgibson added P2 Second level priority - Should have Review: XS Code review time: 30 mins or less labels Oct 31, 2018
stephaniehobson
stephaniehobson approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ 🔊

Needs a rebase to deal with the merge conflict. I'm not going to try to fix it with github this time.

@alexgibson
Copy link
Member Author

Thanks @stephaniehobson! Rebased, so merging this one too 👍

@alexgibson alexgibson merged commit 4236c3e into mozilla:master Nov 14, 2018
@alexgibson alexgibson deleted the card-component-rtl branch November 14, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniehobson stephaniehobson stephaniehobson approved these changes

Assignees
No one assigned
Labels
Bug 🪲 Something isn't working P2 Second level priority - Should have Review: XS Code review time: 30 mins or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexgibson @stephaniehobson