This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Fixing tools menu #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
digitarald
commented
Oct 30, 2012
digitarald
commented
- Moving menu item from tools in web developer (fixes Firefox OS Simulator item in Tools menu should be under Web Developer menu #32)
- Removing Install Page menu
- Removing Install Page menu
|
|
||
| Menuitems.Menuitem({ | ||
| id: "appmenu_webDeveloper_popup", | ||
| menuid: "appmenu_webDeveloper_popup", |
There was a problem hiding this comment.
id and menuid should have different values. It looks like this menuid is correct, while id should be something like appMenuSimulatorItem.
There was a problem hiding this comment.
(Or, if we want to be consistent with the appmenu code in Firefox: appmenu_simulator.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.