Match headings on trimmed strings to avoid whitespace causing mismatches (Fixes #452) #454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@msujaws this should be fairly easy to review. The HTML changes are just because
generate-testcase.js
changes some formatting to how the HTML used to be.The reason we have all this code is to deal with cases where the title is something like "New York Times - Some title", so we remove the generic website name stuff. This code then looks to see if the prefix might actually just be a legit part of the title by checking headings inside the page for the same title. As noted in #452 this fixes the engadget title, but as you can see here it also improves the telegraph testcase, so it seems plausible it'll affect a good number of articles.