Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #81 - Keep article images. #82

Merged
merged 2 commits into from Mar 31, 2015
Merged

Fixes #81 - Keep article images. #82

merged 2 commits into from Mar 31, 2015

Conversation

n1k0
Copy link
Contributor

@n1k0 n1k0 commented Mar 27, 2015

Not super sure with this one, though that fixes #81 and doesn't break the rest of tests.

r? @leibovic @gijsk

@gijsk
Copy link
Contributor

gijsk commented Mar 30, 2015

It seems like the basic idea here was to remove items which contain more images than paragraphs. I don't know why that'd be desirable. Has anyone looked at the archaeology here to figure out why?

@n1k0
Copy link
Contributor Author

n1k0 commented Mar 30, 2015

It was already there in arc90's first released version. Hard to figure out what's the exact reasoning behind this…

@gijsk
Copy link
Contributor

gijsk commented Mar 31, 2015

Hm. At the point where we remove the container, can we check if either it or its parent is a <figure> ? That would be a more conservative change and would also fix this issue.

@n1k0
Copy link
Contributor Author

n1k0 commented Mar 31, 2015

Good idea, will do.

@n1k0
Copy link
Contributor Author

n1k0 commented Mar 31, 2015

Now that's annoying, tests are green on my box while one of them breaks on Travis. Both envs are up to date. Oh dear.

@n1k0
Copy link
Contributor Author

n1k0 commented Mar 31, 2015

Ohh that's nice, only one of the two Travis builds is failing. That means intermittent I guess? Oh dear.

@n1k0
Copy link
Contributor Author

n1k0 commented Mar 31, 2015

Bah, that was just because I didn't rebase.

@n1k0 n1k0 force-pushed the keep-images branch 4 times, most recently from 96c4ccb to b0cdad6 Compare March 31, 2015 17:10
@gijsk
Copy link
Contributor

gijsk commented Mar 31, 2015

\o/

gijsk added a commit that referenced this pull request Mar 31, 2015
Fixes #81 - Keep article images.
@gijsk gijsk merged commit 87e4fbb into master Mar 31, 2015
@gijsk gijsk deleted the keep-images branch March 31, 2015 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some images are still erroneously stripped out from content
2 participants