This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks,
This is a much improved dockerfile I thought to prepare for you with some docker best-practices. Here it goes:
WORKDIR
,apt-get install
etc. This way when only your code changes these docker layers will not get invalidated.apt-get update
andapt-get install
s in the same line, otherwise you will eventually end up with docker images that cannot get build because theapt-get update
will be cached and pointing to packages that no longer exist. See for more caching and “apt-get update” moby/moby#3313ADD
is a complicated command with lots of magic (url downloading, auto tarball extraction, etc). Try to useCOPY
instead and limitADD
use to the absolute necessary.More can be done like create a user and run based on that user which will help with file permissions on the host too.
Enjoy!