This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Add a few query tests #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackebrot
suggested changes
Aug 7, 2018
There was a problem hiding this comment.
Great work @jrbenny35! 👏
One comment on type annotations.
Currently the tests check that the first search result is what we expect. Ideally we also check that the search results don't contain items that do not match the search string. We could do this by additionally assertion the number of results?
What do you think?
tests/test_queries.py
Outdated
| @@ -15,14 +16,93 @@ | |||
| ("Ashleys Query", "Query created by Ashley."), | |||
| ], | |||
| ) | |||
| def test_query( | |||
| def test_query_by_username( | |||
| create_queries, | |||
There was a problem hiding this comment.
Can you please update this to:
create_queries: typing.Callable[..., None],
|
I think asserting the number of results could work but what if they query is like 'default query' but there is one named 'default query 1' ? |
|
That depends on the expected behavior for the search feature of Redash. Thoughts @madalincm? |
|
Just trying it myself, they both show up. |
This was referenced Aug 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63 #62 #64 #61 #65 #59