This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
staticanalysis/bot: clang-format reformats code that is correctly formatted #1815
Labels
Comments
abpostelnicu
added a commit
that referenced
this issue
Jan 23, 2019
abpostelnicu
added a commit
that referenced
this issue
Jan 23, 2019
abpostelnicu
added a commit
to abpostelnicu/release-services
that referenced
this issue
Jan 23, 2019
abpostelnicu
added a commit
to abpostelnicu/release-services
that referenced
this issue
Jan 23, 2019
abpostelnicu
added a commit
to abpostelnicu/release-services
that referenced
this issue
Jan 23, 2019
abpostelnicu
added a commit
to abpostelnicu/release-services
that referenced
this issue
Jan 23, 2019
abpostelnicu
added a commit
that referenced
this issue
Jan 23, 2019
abpostelnicu
added a commit
that referenced
this issue
Jan 25, 2019
* bot/staticanalysis: Run clang-format on each file from the patch. (#1815)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The first thing that the bot does is to performa a
./mach clang-format
[1], that translates to running clang-format on a diff[2].In most cases this is fine but there are some scenarios where context is needed by clang-format to better determine the token types that need to be reformat and thus errors happen, please see [3] and [4].
Since we already formatted the entire repo I think it's safe to assume that we want to do a
per file
basis format where we call:./mach clang-format -p file
for all of the eligible files from the patch.
The text was updated successfully, but these errors were encountered: