Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

shipit_static_analysis: Problem with an automated review when using gtest infrastructure #674

Closed
jyavenard opened this issue Oct 17, 2017 · 1 comment

Comments

@jyavenard
Copy link

MozReview URL: https://reviewboard.mozilla.org/r/…

Problem:
The code creates issues for existing code, and code that is from external framework.

Example:
https://reviewboard.mozilla.org/r/189112/#issue-summary

This prevents from writing gtest.

@jankeromnes
Copy link
Contributor

Indeed, sorry for all the noise! Thank you for filing this issue, and please drop all these unhelpful MozReview comments.

As mentioned in our mailing list, this was originally reported as #658, and the fix should get to production some time tomorrow, after which our bot will stop complaining about these TEST macros.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants