Conversation
Thank you for following up on this! It can work with Janitor if we install a few additional dependencies (Cloud9 SDK and noVNC). Also in general, I like to install the latest stable tools that developers might need or like, to make images really convenient to use, and I also create a user called "user" and place all sources in That's why I usually base all Janitor project images on top of ubuntu-dev (basically Ubuntu 16.04 with a lot of nice recent/pre-configured tools). However, I think I will need to adapt this base Dockerfile to work on top of pre-existing developer images (e.g. to apply it on top of your |
@jankeromnes Do you have a list of this tools? I'm not sure we should add this tools to docker image, but rather into build environment of each project. Adding it to docker image would ignore people that does not use docker for development. Adding tools per project (eg. each python package gets pdbbb as a buildtime dependency) would result ending up in docker file as would in your case, just they would bubble up from project specification. In any case I would love to review this list of tools with you and document them somewhere. Regarding |
Yes, it's all the tools installed in https://github.com/JanitorTechnology/dockerfiles/blob/master/ubuntu-dev/ubuntu-dev.dockerfile, most notably:
Basing images on top of I would love to adapt this utilities Dockerfile with |
@jankeromnes i see, i'll add |
@garbas interesting, if that works it will mean less work for me, but I do believe that I'll have to build some Janitor images on top of foreign images at some point anyway, so I could also adapt your developer image as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was closed unmerged. Dismissing the review request, but I'd be excited to help out if this project gets picked up again!
@jankeromnes This is a follow up on the meeting we had some time ago.
Running
./please tools base-image --dev --docker-username=??? --docker-password=???
should now generate and push 2 docker images (base-latest and dev-latest).Can you test if
mozillareleng/services:dev-latest
image will work with Janitor?ps. i'm just running the command so it might take 30min for image to be there.