Finish Enum work for URL

mozilla · May 6, 2024 · e369dc9 · e369dc9
1 parent 5c41287
commit e369dc9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -108,6 +108,9 @@ List of external sources that the app is pulling data from:
 - https://aus-api.mozilla.org/api/v1/
 - https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
 
+The list of domains used to get data is listed at this API endpoint:
+https://whattrainisitnow.com/api/external/
+
 Emptying the mutable data in the cache folder (either via the `composer cache:clear` command or by doing `rm cache/*.cache ; rm -rf cache/twig/*`) should fix any issue caused by external data sources listed above being unavailable and/or providing bogus data.
 
 Restarting the app should solve most problems on production.

diff --git a/app/classes/ReleaseInsights/Request.php b/app/classes/ReleaseInsights/Request.php
@@ -65,7 +65,7 @@ public function getController(): string
             '/about/'                     => 'about',
             '/nightly/'                   => 'nightly',
             '/release/'                   => 'release',
-            '/api/external/'               => 'api/external',
+            '/api/external/'              => 'api/external',
             '/api/nightly/'               => 'api/nightly',
             '/api/release/schedule/'      => 'api/release_schedule',
             '/api/esr/releases/'          => 'api/esr_releases',

diff --git a/app/classes/ReleaseInsights/URL.php b/app/classes/ReleaseInsights/URL.php
@@ -11,5 +11,6 @@ enum URL: string {
     case Mercurial      = 'https://hg.mozilla.org/';
     case Balrog         = 'https://aus-api.mozilla.org/api/v1/';
     case Socorro        = 'https://crash-stats.mozilla.org/api/';
+    case Archive        = 'https://archive.mozilla.org/';
     // Balrog staging: https://stage.balrog.nonprod.cloudops.mozgcp.net
 }
diff --git a/app/models/nightly.php b/app/models/nightly.php
@@ -25,7 +25,7 @@
 if (empty($nightlies)) {
     // Get the latest nightly build ID, used as a tooltip on the nightly version number
     $latest_nightly = Utils::getJson(
-        'https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/firefox-' . FIREFOX_NIGHTLY . '.en-US.win64.json',
+        URL::Archive->value .  'pub/firefox/nightly/latest-mozilla-central/firefox-' . FIREFOX_NIGHTLY . '.en-US.win64.json',
         900
     );