This repository has been archived by the owner on Feb 2, 2019. It is now read-only.
Specify build properties in extra #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2016 11:44
| locales: ["en-US"] | ||
| branch: {{ branch }} | ||
| platform: {{ platform }} | ||
| version: "{{ version }}" |
There was a problem hiding this comment.
Yeah. We hit a bug when 45.0 was interpreted as 45.
There was a problem hiding this comment.
should we stick product in here now to prep for upcoming fennec or will we have logic against platform?
There was a problem hiding this comment.
I think we will revisit this multiple times :)
|
🚀 it |
rail
pushed a commit
that referenced
this pull request
Mar 11, 2016
Specify build properties in extra
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mozilla/mozmill-ci#764