Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unassign inactive people on bugs #266

Closed
pascalchevrel opened this issue Nov 27, 2018 · 14 comments · Fixed by #1292, #1297, #1310, #1340 or #1377
Closed

Unassign inactive people on bugs #266

pascalchevrel opened this issue Nov 27, 2018 · 14 comments · Fixed by #1292, #1297, #1310, #1340 or #1377
Assignees

Comments

@pascalchevrel
Copy link
Member

Some bugs have an assignee but the person has not logged into Bugzilla in years so they should be unassigned to these bugs so as to reflect the reality that they won't fix them.

Example:
https://bugzilla.mozilla.org/user_profile?user_id=105243
user last activity on bugzilla:
2015-06-01

But 29 bugs are still assigned to this person:
https://bugzilla.mozilla.org/buglist.cgi?list_id=14449526&emailtype1=exact&emailassigned_to1=1&email1=asaf%40sent.com&query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED

@sylvestre
Copy link
Contributor

image
(because I will reset them)

@calixteman calixteman self-assigned this Dec 11, 2018
@calixteman
Copy link
Contributor

The tool has been added in:
0255ea0#diff-8e8954919b092f3dea2976a96bf61ef8
but it isn't activated yet.
@sylvestre what do we do here ?

@sylvestre
Copy link
Contributor

sylvestre commented Mar 5, 2019 via email

@calixteman
Copy link
Contributor

It isn't always easy to guess who is a former employee and I hope that there is not so many bugs like this. But for easy cases (bz mail ending with mozilla.com) we can do that.
For the other ones, I don't know...
@lizzard, @emceeaich, @pascalchevrel, @marco-c wdyt ?

@pascalchevrel
Copy link
Member Author

needinfo the triage owner is fine for me, bugs that are assigned to somebody that is not active are also bugs that can't be taken by volunteers btw. If the triage owner doesn't take any action in x months, we can decide to unassign then.

@emceeaich
Copy link
Contributor

Searching for assignee = %group.mozilla-corporation% will find active staff and %group.editbugs% anyone with editbugs, but I can't think of anything we do that captures "was staff when assigned bug" but not staff now.

To avoid this in the future we should be un-assigning bugs when we off-board staff, and maybe create a mozilla-corporation-alumni group? I'll follow up in a BMO bug for the later.

@pascalchevrel
Copy link
Member Author

I don't think that unassigning bugs from previous staff members is the way to go, you have people that left mozilla but still work on bugs that were assigned to them (xidorn and mounir for example or more recently dietrich) because their new job is compatible with contributing with Mozilla. it is the activity in the mozilla project that matters.

@marco-c
Copy link
Contributor

marco-c commented Feb 15, 2022

I propose we unassign inactive people without adding a needinfo if the last activity in the bug is older than three months and add the needinfo if the last activity in the bug is more recent.
This way we'd add, at the moment, less than 40 needinfos.

What do you think? @calixteman @pascalchevrel @sylvestre

@pascalchevrel
Copy link
Member Author

I think that 3 months is too short for people working on long term platform bugs (spec implementation for example) which is work that can span a couple of years.

@marco-c
Copy link
Contributor

marco-c commented Feb 15, 2022

With 1 year it would be 100 needinfos. The problem with that is that we'd needinfo some triage owners on a lot of bugs (e.g. aosmond for Core::ImageLib).
My thinking is that this way we get to a clean slate without making too much noise, and for the future we are going to add needinfo on all bugs where the assignee is inactive.

@marco-c
Copy link
Contributor

marco-c commented Feb 15, 2022

I've opened #1292 to start enabling it with the limitation on last activity, we can always change the limitation or remove it, but I think it's good to at least start somewhere.

@calixteman
Copy link
Contributor

I deleted my previous message because I misunderstood the issue.
Anyway I'm fine to auto-remove assignee without a ni.
We can check in the next days how people are handling their ni: today I saw one dev who was just cancelling his nis.

@marco-c
Copy link
Contributor

marco-c commented Feb 21, 2022

We have seen a few examples of good outcome from this, so we can slowly (maybe every 2 weeks) increase the last activity threshold (from 3 to 6 months, then from 6 months to 1 year, then from 1 year to 2 years, then we totally remove the threshold).

@marco-c marco-c linked a pull request Feb 21, 2022 that will close this issue
marco-c added a commit to marco-c/relman-auto-nag that referenced this issue Feb 21, 2022
calixteman added a commit that referenced this issue Feb 23, 2022
…within the previous 6 months (#1297)

Part of #266

Co-authored-by: calixteman <calixte.denizet@gmail.com>
@marco-c marco-c reopened this Feb 23, 2022
marco-c added a commit to marco-c/relman-auto-nag that referenced this issue Mar 8, 2022
suhaibmujahid pushed a commit that referenced this issue Mar 9, 2022
marco-c added a commit to marco-c/relman-auto-nag that referenced this issue Apr 5, 2022
…bugs

To avoid adding hundreds of needinfos to triage owners, run the script weekly
and add a limit on the number of needinfos.

Fixes mozilla#266
marco-c added a commit to marco-c/relman-auto-nag that referenced this issue Apr 5, 2022
…bugs

To avoid adding hundreds of needinfos to triage owners, run the script weekly
and add a limit on the number of needinfos.

Fixes mozilla#266
marco-c added a commit that referenced this issue Apr 5, 2022
…bugs (#1377)

To avoid adding hundreds of needinfos to triage owners, run the script weekly
and add a limit on the number of needinfos.

Fixes #266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment