Skip to content
This repository has been archived by the owner on Apr 1, 2019. It is now read-only.

[#163] Generate locale dirs #182

Merged
merged 1 commit into from
Jan 15, 2016
Merged

[#163] Generate locale dirs #182

merged 1 commit into from
Jan 15, 2016

Conversation

k88hudson
Copy link
Contributor

This generates a build for all locales and channels in /build when npm run build is run.

The npm start task still uses the www directory and only outputs en-US.

@k88hudson
Copy link
Contributor Author

@rlr would you mind reviewing?

@rlr
Copy link
Contributor

rlr commented Jan 15, 2016

\me looks

@@ -4,3 +4,4 @@ node_modules
build/
logs/
www/
build/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird. build/ was already there 3 lines above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh whoops!

@rlr
Copy link
Contributor

rlr commented Jan 15, 2016

I am getting this error:

> node ./bin/generate-directories --static www -o build

module.js:339
    throw err;
    ^

Error: Cannot find module 'glob'
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/rlr/dev/remote-newtab/bin/generate-directories.js:3:14)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Function.Module.runMain (module.js:467:10)

npm ERR! Darwin 15.2.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7
npm ERR! code ELIFECYCLE
npm ERR! newtab@0.0.0 postbuild: `node ./bin/generate-directories --static www -o build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the newtab@0.0.0 postbuild script 'node ./bin/generate-directories --static www -o build'.
npm ERR! This is most likely a problem with the newtab package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ./bin/generate-directories --static www -o build
npm ERR! You can get their info via:
npm ERR!     npm owner ls newtab
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/rlr/dev/remote-newtab/npm-debug.log

@k88hudson
Copy link
Contributor Author

@rlr ok should be good

@rlr
Copy link
Contributor

rlr commented Jan 15, 2016

it worked!!!!!!!!!!! r+

k88hudson added a commit that referenced this pull request Jan 15, 2016
@k88hudson k88hudson merged commit 9a4bc5b into master Jan 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants