This repository has been archived by the owner on Apr 1, 2019. It is now read-only.
Renamed Rect + type coercion (closes #50, #51) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
force-pushed
the
Rectangle
branch
2 times, most recently
from
e5f03f8
to
76726f0
Compare
marcoscaceres
changed the title
marcoscaceres
force-pushed
the
Rectangle
branch
4 times, most recently
from
026c40d
to
90d03a8
Compare
|
@emtwo ? |
marcoscaceres
force-pushed
the
Rectangle
branch
from
90d03a8
to
b0338dd
Compare
|
@oyiptong r? |
|
r+ |
|
This PR says that the commit got merged, but I don't see it in https://github.com/mozilla/remote-newtab/commits/gh-pages weird? |
|
Just for record keeping. We recovered the commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.