use node-convict for configuration; reorg directory structure to bin/,lib/; use const/let as appropriate #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladikoff
approved these changes
Aug 7, 2018
|
|
||
| // Domain whitelist. RCPT TO addresses must match one of the domains on this | ||
| // list. (Strict matching, no subdomains). | ||
| rcptToDomainWhitelist: { |
| webPort: { | ||
| 'default': 8080, | ||
| doc: 'Port number for web server to listen on.', | ||
| env: 'WEB_PORT', |
There was a problem hiding this comment.
nit: I like the EMAIL_PORT, but i am not sure if we have to specify the WEB_ here, can we just use PORT?
There was a problem hiding this comment.
We could. But symmetry? I find it odd that one gets to be PORT and the other not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config changes are one step to moving this someday to standard dockerflow.
r? - @jbuck or @vladikoff