a bit cleanup for the PR; make the old function markFunctionStart(int…

…) deprecated and do not use the old stuff internally
mozilla · Apr 27, 2024 · a3dfe64 · a3dfe64
1 parent 709874b
commit a3dfe64
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/org/mozilla/javascript/Decompiler.java b/src/org/mozilla/javascript/Decompiler.java
@@ -74,6 +74,8 @@ int markFunctionStart(int functionType, boolean isGenerator) {
         return savedOffset;
     }
 
+    /** @deprecated use {@link #markFunctionStart(int, boolean)} instead */
+    @Deprecated
     int markFunctionStart(int functionType) {
         return markFunctionStart(functionType, false);
     }

diff --git a/src/org/mozilla/javascript/IRFactory.java b/src/org/mozilla/javascript/IRFactory.java
@@ -687,7 +687,7 @@ private Node transformGenExpr(GeneratorExpression node) {
         fn.setRequiresActivation();
 
         int functionType = fn.getFunctionType();
-        int start = decompiler.markFunctionStart(functionType);
+        int start = decompiler.markFunctionStart(functionType, false);
         Node mexpr = decompileFunctionHeader(fn);
         int index = parser.currentScriptOrFn.addFunction(fn);
 

diff --git a/testsrc/jstests/harmony/generators-basic.js b/testsrc/jstests/harmony/generators-basic.js
@@ -163,7 +163,6 @@ assertEquals(undefined, r.value);
 assertTrue(r.done);
 
 // toString returns the correct value
-
 assertEquals("\nfunction* gen() {\n    for (var i = 0; i < 3; i++) {\n        yield i;\n    }\n}\n", gen.toString());
 
 "success";