Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parent-child relationship in TaggedTemplateLiteral #1238

Closed
kuzjka opened this issue Jun 17, 2022 · 1 comment
Closed

Parent-child relationship in TaggedTemplateLiteral #1238

kuzjka opened this issue Jun 17, 2022 · 1 comment
Labels
bug Issues considered a bug

Comments

@kuzjka
Copy link
Contributor

kuzjka commented Jun 17, 2022

Hi,

Our team is really happy to see string templates and tagged string templates support in Rhino 1.7.14.

However, I have noticed that descendants of TaggedTemplateLiteral node, which are tag (target) and string literal, don't have parent relationship with TaggedTemplateLiteral node.

It looks a little illogical to me, and among other things, breaks getAstRoot().

If parent is not set intentionally, please let me know.

I'll try to prepare a PR with tests and a fix soon.

Best regards,
Ihor.
kuzjka added a commit to kuzjka/rhino that referenced this issue Jun 17, 2022
@kuzjka
test: added tests for mozilla#1238
50d0575
kuzjka added a commit to kuzjka/rhino that referenced this issue Jun 17, 2022
@kuzjka
fix: parent relationship in TaggedTemplateLiteral (mozilla#1238)
a2fcc18
@kuzjka kuzjka mentioned this issue Jun 17, 2022
Merged
@rbri
Copy link
Collaborator

rbri commented Jun 21, 2022

LGTM

@p-bakker p-bakker added bug Issues considered a bug labels Jul 1, 2022
@gbrail gbrail closed this as completed in 2daadfc Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues considered a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kuzjka @rbri @p-bakker