You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our team is really happy to see string templates and tagged string templates support in Rhino 1.7.14.
However, I have noticed that descendants of TaggedTemplateLiteral node, which are tag (target) and string literal, don't have parent relationship with TaggedTemplateLiteral node.
It looks a little illogical to me, and among other things, breaks getAstRoot().
If parent is not set intentionally, please let me know.
I'll try to prepare a PR with tests and a fix soon.
Best regards,
Ihor.
The text was updated successfully, but these errors were encountered:
kuzjka
added a commit
to kuzjka/rhino
that referenced
this issue
Jun 17, 2022
Hi,
Our team is really happy to see string templates and tagged string templates support in Rhino 1.7.14.
However, I have noticed that descendants of
TaggedTemplateLiteral
node, which are tag (target) and string literal, don't have parent relationship withTaggedTemplateLiteral
node.It looks a little illogical to me, and among other things, breaks
getAstRoot()
.If parent is not set intentionally, please let me know.
I'll try to prepare a PR with tests and a fix soon.
Best regards,
Ihor.
The text was updated successfully, but these errors were encountered: