Fix for #616

[stijnkliemesch]

Affects strict mode only.

No longer prematurely throws a TypeError in ScriptableObject.putImpl(Object,int,Scriptable,Object) when instance member isExtensible is false.

Instead, now it first queries the slotmap, so that if a GetterSlot instance is returned, any present setter may be called. All other outcomes of this method should be unaffected.

[stijnkliemesch]

Do I add the testcase as a new .js file somewhere in test262/test/built-ins/Object/ like in freeze/ or preventExtensions/ ?

[stijnkliemesch]

Also, after this commit, the tests show the following output:

org.mozilla.javascript.tests.Test262SuiteTest STANDARD_OUT
    Test is marked as failing but it does not: test262/test/built-ins/Object/freeze/15.2.3.9-2-c-3.js
    Test is marked as failing but it does not: test262/test/built-ins/Object/freeze/15.2.3.9-2-c-2.js
    Test is marked as failing but it does not: test262/test/built-ins/Object/freeze/15.2.3.9-2-c-4.js

Yet the tests seem to "succeed" despite this. Is this a blocking issue?

[gbrail]

Those messages are from the Test262 driver. Basically, some tests are disabled in the file test262.properties, but for some reason (I don't recall why) they were run anyway and passed.

That's a good thing -- it means that we pass more of the test262 suite now -- and we want to preserve our progress by re-enabling those tests so that we don't regress.

Can you take a look at test262 properties and see if modifying that file makes the warnings go away? If you can't figure out I can probably do it later.

[stijnkliemesch]

Do these 3 extra activated Test262 testcases already cover the issue well enough, or is there still a testcase required for showing #616 is fixed ?

[rbri]

Looks god for me - only the curly brackets for the if statements are missing from my point of view.
Have done some simple performance checks on my local machine and i found no negative impact.

@gbrail please merge as soon as possible :-)