Add support for lambda-based native functions #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces LambdaFunction and LambdaConstructor, which can be used to represent Java lambda functions as native JavaScript functions, and also can be used to construct an entire class out of lambdas. This pattern is a more direct representation of the JavaScript object model to Java than the existing reflection mechanism, and it is usable with far less code than the IdScriptableObject class. It also outperforms both in microbenchmarks.
p-bakker
added
enhancement
Java Interop
p-bakker
added
Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces LambdaFunction and LambdaConstructor, which can be used
to represent Java lambda functions as native JavaScript functions,
and also can be used to construct an entire class out of lambdas.
This pattern is a more direct representation of the JavaScript object
model to Java than the existing reflection mechanism, and it is usable
with far less code than the IdScriptableObject class. It also outperforms
both in microbenchmarks.
This just adds the new classes -- I'm hoping to use them to get Promises working very soon. The test in this PR, and the benchmark, show how the new classes might be used to implement new native classes. This all seems easier to me than what we have today -- PTAL and let me know if you agree.