add new StackStyle.MOZILLA_LF #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotlessApply StackStyle.java spotlessApply StackTraceExtensionMozillaLfTest.java spotlessApply StackTraceExtensionMozillaTest.java spotlessApply StackTraceExtensionRhinoTest.java spotlessApply StackTraceExtensionV8Test.java spotlessApply StackTraceTest.java
|
This one makes sense to me and it's pretty low risk. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HtmlUnit is mainly a testing framework and we are using the mozilla StackStyle. To have stable tests the stack trace should not be system dependent. And the modern browsers are also using \n on all platforms.
To be backward compatible i have introduced a new StackStyle.
See HtmlUnit/htmlunit#284.