Refactor SlotMap and Slot classes #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that Slot and all related classes are separate classes now and not just nested inside ScriptableObject. Also, break the two Slot implementations (regular and "GetterSlot") into four so we can use inheritance rather than complex "instanceof" logic to implement the different types of slots. This will be helpful as I'd like to introduce a lambda-based Slot and it was too much complexity the old way.
tonygermano
reviewed
May 19, 2021
rbri
approved these changes
May 19, 2021
rbri
reviewed
May 19, 2021
rbri
reviewed
May 19, 2021
rbri
reviewed
May 19, 2021
rbri
reviewed
May 19, 2021
|
I'm going to experiment with a different package -- but it's going to make this an even bigger PR. |
|
Moving the package is going to result in a ton of changes because of use of package-protected fields and methods. I'm going to leave these classes in the main package and we might consider a change at a future time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that Slot and all related classes are separate classes now and not just nested inside ScriptableObject.
Also, break the two Slot implementations (regular and "GetterSlot") into four so we can use inheritance rather than complex "instanceof" logic to implement the different types of slots.
This simplifies the structure and logic and will make it easier to extend stuff later.