Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix various clippy nits #65

Merged
merged 1 commit into from
Jul 31, 2018
Merged

fix various clippy nits #65

merged 1 commit into from
Jul 31, 2018

Conversation

ncloudioj
Copy link
Member

Had a chance to try out rust-clippy, it reported a few nits and code simplifications that seemed legit.

Didn't take its suggestion of explicit lifetimes given in parameter types where they could be elided though, I figure perhaps those life time tags were annotated there intentionally.

@mykmelez mykmelez self-requested a review July 31, 2018 20:16
Copy link
Contributor

@mykmelez mykmelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry for the delay reviewing! It looks like my "watching" status for this repo got reset to "not watching" somehow, so I never received a notice about the PR.

This all looks good, so I'll merge it. Is it possible to include a clippy check in testing, so we avoid re-introducing these nits in the future?

Didn't take its suggestion of explicit lifetimes given in parameter types where they could be elided though, I figure perhaps those life time tags were annotated there intentionally.

They may well have been, although Rust may also have become better at inferring lifetimes, so it's perhaps worth looking at these (in a separate branch).

@mykmelez mykmelez merged commit ca041e9 into mozilla:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants