Skip to content

Commit

Permalink
fixup! codegen_llvm: check inline assembly constraints with LLVM
Browse files Browse the repository at this point in the history
  • Loading branch information
levex committed Sep 26, 2018
1 parent ecd51ed commit 0991d20
Show file tree
Hide file tree
Showing 2 changed files with 68 additions and 0 deletions.
47 changes: 47 additions & 0 deletions src/test/ui/inline-asm-bad-constraint.rs
@@ -0,0 +1,47 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test that the compiler will catch invalid inline assembly constraints.

#![feature(asm)]

extern "C" {
fn foo(a: usize);
}

fn main() {
bad_register_constraint();
bad_input();
wrong_size_output();
}

// Issue #54130
fn bad_register_constraint() {
let rax: u64;
unsafe {
asm!("" :"={rax"(rax)) //~ ERROR E0668
};
println!("Accumulator is: {}", rax);
}

// Issue #54376
fn bad_input() {
unsafe {
asm!("callq $0" : : "0"(foo)) //~ ERROR E0668
};
}

fn wrong_size_output() {
let rax: u64 = 0;
unsafe {
asm!("addb $1, $0" : "={rax}"((0i32, rax))); //~ ERROR E0668
}
println!("rax: {}", rax);
}
21 changes: 21 additions & 0 deletions src/test/ui/inline-asm-bad-constraint.stderr
@@ -0,0 +1,21 @@
error[E0668]: malformed inline assembly
--> $DIR/inline-asm-bad-constraint.rs:29:9
|
LL | asm!("" :"={rax"(rax)) //~ ERROR E0668
| ^^^^^^^^^^^^^^^^^^^^^^

error[E0668]: malformed inline assembly
--> $DIR/inline-asm-bad-constraint.rs:37:9
|
LL | asm!("callq $0" : : "0"(foo)) //~ ERROR E0668
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0668]: malformed inline assembly
--> $DIR/inline-asm-bad-constraint.rs:44:9
|
LL | asm!("addb $1, $0" : "={rax}"((0i32, rax))); //~ ERROR E0668
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0668`.

0 comments on commit 0991d20

Please sign in to comment.