Skip to content

Commit

Permalink
Fix unused_result lint triggering when a function returns () or !
Browse files Browse the repository at this point in the history
Add a test for this case
  • Loading branch information
pengowen123 committed Aug 11, 2017
1 parent 38bdbb7 commit 0b2c9f0
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/librustc_lint/unused.rs
Expand Up @@ -146,6 +146,8 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnusedResults {

let t = cx.tables.expr_ty(&expr);
let ty_warned = match t.sty {
ty::TyTuple(ref tys, _) if tys.is_empty() => return,
ty::TyNever => return,
ty::TyAdt(def, _) => check_must_use(cx, def.did, s.span, ""),
_ => false,
};
Expand Down
26 changes: 26 additions & 0 deletions src/test/ui/issue-43806.rs
@@ -0,0 +1,26 @@
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// run-pass

#![deny(unused_results)]

fn foo() {}

fn bar() -> ! {
loop {}
}

fn qux() {
foo();
bar();
}

fn main() {}

0 comments on commit 0b2c9f0

Please sign in to comment.