Skip to content

Commit

Permalink
Adjusts all rust doc test to use expect and should_panic
Browse files Browse the repository at this point in the history
- All Rust Doc tests execute the same command `/bin/cat file.txt` which
  `should_panic` on all platforms consistently, because either
  `/bin/cat` or `file.txt` do not exist.
  • Loading branch information
lukaspustina committed Mar 21, 2016
1 parent 4551794 commit 0dd5f67
Showing 1 changed file with 13 additions and 14 deletions.
27 changes: 13 additions & 14 deletions src/libstd/process.rs
Expand Up @@ -38,10 +38,10 @@ use sys_common::{AsInner, AsInnerMut, FromInner, IntoInner};
/// let mut child = Command::new("/bin/cat")
/// .arg("file.txt")
/// .spawn()
/// .unwrap_or_else(|e| { panic!("failed to execute child: {}", e) });
/// .expect("failed to execute child");
///
/// let ecode = child.wait()
/// .unwrap_or_else(|e| { panic!("failed to wait on child: {}", e) });
/// .expect("failed to wait on child");
///
/// assert!(ecode.success());
/// ```
Expand Down Expand Up @@ -195,7 +195,8 @@ impl FromInner<AnonPipe> for ChildStderr {
/// .arg("-c")
/// .arg("echo hello")
/// .output()
/// .unwrap_or_else(|e| { panic!("failed to execute process: {}", e) });
/// .expect("failed to execute proces");
///
/// let hello = output.stdout;
/// ```
#[stable(feature = "process", since = "1.0.0")]
Expand Down Expand Up @@ -305,11 +306,10 @@ impl Command {
///
/// # Examples
///
/// ```
/// ```should_panic
/// use std::process::Command;
/// let output = Command::new("cat").arg("foo.txt").output().unwrap_or_else(|e| {
/// panic!("failed to execute process: {}", e)
/// });
/// let output = Command::new("/bin/cat").arg("file.txt").output()
/// .expect("failed to execute process");
///
/// println!("status: {}", output.status);
/// println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
Expand All @@ -328,12 +328,11 @@ impl Command {
///
/// # Examples
///
/// ```
/// ```should_panic
/// use std::process::Command;
///
/// let status = Command::new("ls").status().unwrap_or_else(|e| {
/// panic!("failed to execute process: {}", e)
/// });
/// let status = Command::new("/bin/cat").arg("file.txt").status()
/// .expect("failed to execute process");
///
/// println!("process exited with: {}", status);
/// ```
Expand Down Expand Up @@ -511,13 +510,13 @@ impl Child {
/// use std::process::{Command, Stdio};
///
/// let mut child = Command::new("/bin/cat")
/// .stdout(Stdio::piped())
/// .arg("file.txt")
/// .stdout(Stdio::piped())
/// .spawn()
/// .unwrap_or_else(|e| { panic!("failed to execute child: {}", e) });
/// .expect("failed to execute child");
///
/// let ecode = child.wait_with_output()
/// .unwrap_or_else(|e| { panic!("failed to wait on child: {}", e) });
/// .expect("failed to wait on child");
///
/// assert!(ecode.success());
/// ```
Expand Down

0 comments on commit 0dd5f67

Please sign in to comment.