Skip to content

Commit

Permalink
pick a reference issue for absolute-paths future incompatibility info
Browse files Browse the repository at this point in the history
It would be kind of embarrassing to ship with the "issue TBD" message!
  • Loading branch information
zackmdavis committed Oct 20, 2018
1 parent 22cc2ae commit 1ddbd81
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion src/librustc_lint/lib.rs
Expand Up @@ -310,7 +310,7 @@ pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) {
},
FutureIncompatibleInfo {
id: LintId::of(ABSOLUTE_PATHS_NOT_STARTING_WITH_CRATE),
reference: "issue TBD",
reference: "issue #53130 <https://github.com/rust-lang/rust/issues/53130>",
edition: Some(Edition::Edition2018),
},
FutureIncompatibleInfo {
Expand Down
Expand Up @@ -11,7 +11,7 @@ LL | #![warn(rust_2018_compatibility)]
| ^^^^^^^^^^^^^^^^^^^^^^^
= note: #[warn(absolute_paths_not_starting_with_crate)] implied by #[warn(rust_2018_compatibility)]
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

warning: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/suggestions-not-always-applicable.rs:27:5
Expand All @@ -20,5 +20,5 @@ LL | #[foo] //~ WARN: absolute paths must start with
| ^^^^^^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

Expand Up @@ -10,7 +10,7 @@ note: lint level defined here
LL | #![deny(absolute_paths_not_starting_with_crate)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/edition-lint-fully-qualified-paths.rs:34:13
Expand All @@ -19,7 +19,7 @@ LL | let _: <::foo::Baz as foo::Foo>::Bar = ();
| ^^^^^^^^^^ help: use `crate`: `crate::foo::Baz`
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: aborting due to 2 previous errors

6 changes: 3 additions & 3 deletions src/test/ui/rust-2018/edition-lint-nested-empty-paths.stderr
Expand Up @@ -10,7 +10,7 @@ note: lint level defined here
LL | #![deny(absolute_paths_not_starting_with_crate)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/edition-lint-nested-empty-paths.rs:31:5
Expand All @@ -19,7 +19,7 @@ LL | use foo::{bar::{XX, baz::{}}};
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `crate`: `crate::foo::{bar::{XX, baz::{}}}`
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/edition-lint-nested-empty-paths.rs:35:5
Expand All @@ -28,7 +28,7 @@ LL | use foo::{bar::{baz::{}, baz1::{}}};
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `crate`: `crate::foo::{bar::{baz::{}, baz1::{}}}`
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: aborting due to 3 previous errors

4 changes: 2 additions & 2 deletions src/test/ui/rust-2018/edition-lint-nested-paths.stderr
Expand Up @@ -10,7 +10,7 @@ note: lint level defined here
LL | #![deny(absolute_paths_not_starting_with_crate)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/edition-lint-nested-paths.rs:31:13
Expand All @@ -19,7 +19,7 @@ LL | use foo::{self as x, c};
| ^^^^^^^^^^^^^^^^^^^ help: use `crate`: `crate::foo::{self as x, c}`
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: aborting due to 2 previous errors

14 changes: 7 additions & 7 deletions src/test/ui/rust-2018/edition-lint-paths.stderr
Expand Up @@ -10,7 +10,7 @@ note: lint level defined here
LL | #![deny(absolute_paths_not_starting_with_crate)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/edition-lint-paths.rs:28:9
Expand All @@ -19,7 +19,7 @@ LL | use bar;
| ^^^ help: use `crate`: `crate::bar`
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/edition-lint-paths.rs:33:9
Expand All @@ -28,7 +28,7 @@ LL | use {Bar as SomethingElse, main};
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `crate`: `crate::{Bar as SomethingElse, main}`
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/edition-lint-paths.rs:45:5
Expand All @@ -37,7 +37,7 @@ LL | use bar::Bar;
| ^^^^^^^^ help: use `crate`: `crate::bar::Bar`
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/edition-lint-paths.rs:57:9
Expand All @@ -46,7 +46,7 @@ LL | use *;
| ^ help: use `crate`: `crate::*`
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/edition-lint-paths.rs:62:6
Expand All @@ -55,7 +55,7 @@ LL | impl ::foo::SomeTrait for u32 { }
| ^^^^^^^^^^^^^^^^ help: use `crate`: `crate::foo::SomeTrait`
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: absolute paths must start with `self`, `super`, `crate`, or an external crate name in the 2018 edition
--> $DIR/edition-lint-paths.rs:67:13
Expand All @@ -64,7 +64,7 @@ LL | let x = ::bar::Bar;
| ^^^^^^^^^^ help: use `crate`: `crate::bar::Bar`
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: aborting due to 7 previous errors

2 changes: 1 addition & 1 deletion src/test/ui/rust-2018/extern-crate-rename.stderr
Expand Up @@ -10,7 +10,7 @@ note: lint level defined here
LL | #![deny(absolute_paths_not_starting_with_crate)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: aborting due to previous error

2 changes: 1 addition & 1 deletion src/test/ui/rust-2018/extern-crate-submod.stderr
Expand Up @@ -10,7 +10,7 @@ note: lint level defined here
LL | #![deny(absolute_paths_not_starting_with_crate)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
= note: for more information, see issue TBD
= note: for more information, see issue #53130 <https://github.com/rust-lang/rust/issues/53130>

error: aborting due to previous error

0 comments on commit 1ddbd81

Please sign in to comment.