Skip to content

Commit

Permalink
Move comment describing test case
Browse files Browse the repository at this point in the history
  • Loading branch information
dcreager committed Mar 12, 2019
1 parent c641a8c commit 32969e9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
10 changes: 10 additions & 0 deletions src/test/run-make-fulldeps/redundant-libs/Makefile
@@ -1,4 +1,14 @@
-include ../tools.mk

# rustc will remove one of the two redundant references to foo below. Depending
# on which one gets removed, we'll get a linker error on SOME platforms (like
# Linux). On these platforms, when a library is referenced, the linker will
# only pull in the symbols needed _at that point in time_. If a later library
# depends on additional symbols from the library, they will not have been pulled
# in, and you'll get undefined symbols errors.
#
# So in this example, we need to ensure that rustc keeps the _later_ reference
# to foo, and not the former one.
RUSTC_FLAGS = \
-l static=bar \
-l foo \
Expand Down
9 changes: 0 additions & 9 deletions src/test/run-make-fulldeps/redundant-libs/main.rs
Expand Up @@ -8,15 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// rustc will remove one of the two redundant references to foo below. Depending on which one gets
// removed, we'll get a linker error on SOME platforms (like Linux). On these platforms, when a
// library is referenced, the linker will only pull in the symbols needed _at that point in time_.
// If a later library depends on additional symbols from the library, they will not have been
// pulled in, and you'll get undefined symbols errors.
//
// So in this example, we need to ensure that rustc keeps the _later_ reference to foo, and not the
// former one.

extern "C" {
fn bar();
fn baz();
Expand Down

0 comments on commit 32969e9

Please sign in to comment.