Skip to content

Commit

Permalink
add comment about maintaining OsStr encoding
Browse files Browse the repository at this point in the history
  • Loading branch information
TyPR124 committed Mar 20, 2020
1 parent e4a65e8 commit 45416cd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/libstd/ffi/os_str.rs
Expand Up @@ -534,6 +534,8 @@ impl OsStr {
fn from_inner_mut(inner: &mut Slice) -> &mut OsStr {
// Safety: OsStr is just a wrapper of Slice,
// therefore converting &mut Slice to &mut OsStr is safe.
// Any method that mutates OsStr must be careful not to
// break platform-specific encoding, in particular Wtf8 on Windows.
unsafe { &mut *(inner as *mut Slice as *mut OsStr) }
}

Expand Down
2 changes: 2 additions & 0 deletions src/libstd/sys/windows/os_str.rs
Expand Up @@ -87,6 +87,8 @@ impl Buf {
// Safety: Slice is just a wrapper for Wtf8,
// and self.inner.as_mut_slice() returns &mut Wtf8.
// Therefore, transmuting &mut Wtf8 to &mut Slice is safe.
// Additionally, care should be taken to ensure the slice
// is always valid Wtf8.
unsafe { mem::transmute(self.inner.as_mut_slice()) }
}

Expand Down

0 comments on commit 45416cd

Please sign in to comment.