Skip to content

Commit

Permalink
Rename PatUniq to PatBox. Fixes part of #13910.
Browse files Browse the repository at this point in the history
  • Loading branch information
ahmedcharles committed May 28, 2014
1 parent 73dac7e commit 4e3db5e
Show file tree
Hide file tree
Showing 14 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion src/librustc/middle/cfg/construct.rs
Expand Up @@ -113,7 +113,7 @@ impl<'a> CFGBuilder<'a> {
self.add_node(pat.id, [pred])
}

ast::PatUniq(subpat) |
ast::PatBox(subpat) |
ast::PatRegion(subpat) |
ast::PatIdent(_, _, Some(subpat)) => {
let subpat_exit = self.pat(subpat, pred);
Expand Down
6 changes: 3 additions & 3 deletions src/librustc/middle/check_match.rs
Expand Up @@ -383,7 +383,7 @@ fn pat_ctor_id(cx: &MatchCheckCtxt, p: @Pat) -> Option<ctor> {
_ => Some(single)
}
}
PatUniq(_) | PatTup(_) | PatRegion(..) => {
PatBox(_) | PatTup(_) | PatRegion(..) => {
Some(single)
}
PatVec(ref before, slice, ref after) => {
Expand Down Expand Up @@ -763,7 +763,7 @@ fn specialize(cx: &MatchCheckCtxt,
PatTup(args) => {
Some(args.iter().map(|x| *x).collect::<Vec<_>>().append(r.tail()))
}
PatUniq(a) | PatRegion(a) => {
PatBox(a) | PatRegion(a) => {
Some((vec!(a)).append(r.tail()))
}
PatLit(expr) => {
Expand Down Expand Up @@ -919,7 +919,7 @@ fn find_refutable(cx: &MatchCheckCtxt, pat: &Pat, spans: &mut Vec<Span>) {
}

match pat.node {
PatUniq(sub) | PatRegion(sub) | PatIdent(_, _, Some(sub)) => {
PatBox(sub) | PatRegion(sub) | PatIdent(_, _, Some(sub)) => {
find_refutable(cx, sub, spans)
}
PatWild | PatWildMulti | PatIdent(_, _, None) => {}
Expand Down
2 changes: 1 addition & 1 deletion src/librustc/middle/mem_categorization.rs
Expand Up @@ -1064,7 +1064,7 @@ impl<'t,TYPER:Typer> MemCategorizationContext<'t,TYPER> {
}
}

ast::PatUniq(subpat) | ast::PatRegion(subpat) => {
ast::PatBox(subpat) | ast::PatRegion(subpat) => {
// @p1, ~p1
let subcmt = self.cat_deref(pat, cmt, 0);
if_ok!(self.cat_pattern(subcmt, subpat, op));
Expand Down
2 changes: 1 addition & 1 deletion src/librustc/middle/region.rs
Expand Up @@ -671,7 +671,7 @@ fn resolve_local(visitor: &mut RegionResolutionVisitor,
subpats.iter().any(|&p| is_binding_pat(p))
}

ast::PatUniq(subpat) => {
ast::PatBox(subpat) => {
is_binding_pat(subpat)
}

Expand Down
6 changes: 3 additions & 3 deletions src/librustc/middle/trans/_match.rs
Expand Up @@ -838,7 +838,7 @@ fn enter_uniq<'a, 'b>(
let dummy = @ast::Pat {id: 0, node: ast::PatWild, span: DUMMY_SP};
enter_match(bcx, dm, m, col, val, |p| {
match p.node {
ast::PatUniq(sub) => {
ast::PatBox(sub) => {
Some(vec!(sub))
}
_ => {
Expand Down Expand Up @@ -1105,7 +1105,7 @@ macro_rules! any_pat (
)

fn any_uniq_pat(m: &[Match], col: uint) -> bool {
any_pat!(m, ast::PatUniq(_))
any_pat!(m, ast::PatBox(_))
}

fn any_region_pat(m: &[Match], col: uint) -> bool {
Expand Down Expand Up @@ -2270,7 +2270,7 @@ fn bind_irrefutable_pat<'a>(
binding_mode, cleanup_scope);
}
}
ast::PatUniq(inner) => {
ast::PatBox(inner) => {
let llbox = Load(bcx, val);
bcx = bind_irrefutable_pat(bcx, inner, llbox, binding_mode, cleanup_scope);
}
Expand Down
2 changes: 1 addition & 1 deletion src/librustc/middle/trans/debuginfo.rs
Expand Up @@ -2633,7 +2633,7 @@ fn populate_scope_map(cx: &CrateContext,
}
}

ast::PatUniq(sub_pat) | ast::PatRegion(sub_pat) => {
ast::PatBox(sub_pat) | ast::PatRegion(sub_pat) => {
scope_map.insert(pat.id, scope_stack.last().unwrap().scope_metadata);
walk_pattern(cx, sub_pat, scope_stack, scope_map);
}
Expand Down
2 changes: 1 addition & 1 deletion src/librustc/middle/typeck/check/_match.rs
Expand Up @@ -634,7 +634,7 @@ pub fn check_pat(pcx: &pat_ctxt, pat: &ast::Pat, expected: ty::t) {
}
}
}
ast::PatUniq(inner) => {
ast::PatBox(inner) => {
check_pointer_pat(pcx, Send, inner, pat.id, pat.span, expected);
}
ast::PatRegion(inner) => {
Expand Down
2 changes: 1 addition & 1 deletion src/librustdoc/clean/mod.rs
Expand Up @@ -1721,7 +1721,7 @@ fn name_from_pat(p: &ast::Pat) -> String {
PatStruct(..) => fail!("tried to get argument name from pat_struct, \
which is not allowed in function arguments"),
PatTup(..) => "(tuple arg NYI)".to_string(),
PatUniq(p) => name_from_pat(p),
PatBox(p) => name_from_pat(p),
PatRegion(p) => name_from_pat(p),
PatLit(..) => {
warn!("tried to get argument name from PatLit, \
Expand Down
2 changes: 1 addition & 1 deletion src/libsyntax/ast.rs
Expand Up @@ -347,7 +347,7 @@ pub enum Pat_ {
* we don't bind the fields to names */
PatStruct(Path, Vec<FieldPat> , bool),
PatTup(Vec<@Pat> ),
PatUniq(@Pat),
PatBox(@Pat),
PatRegion(@Pat), // reference pattern
PatLit(@Expr),
PatRange(@Expr, @Expr),
Expand Down
2 changes: 1 addition & 1 deletion src/libsyntax/ast_util.rs
Expand Up @@ -657,7 +657,7 @@ pub fn walk_pat(pat: &Pat, it: |&Pat| -> bool) -> bool {
PatEnum(_, Some(ref s)) | PatTup(ref s) => {
s.iter().advance(|&p| walk_pat(p, |p| it(p)))
}
PatUniq(s) | PatRegion(s) => {
PatBox(s) | PatRegion(s) => {
walk_pat(s, it)
}
PatVec(ref before, ref slice, ref after) => {
Expand Down
2 changes: 1 addition & 1 deletion src/libsyntax/fold.rs
Expand Up @@ -760,7 +760,7 @@ pub fn noop_fold_pat<T: Folder>(p: @Pat, folder: &mut T) -> @Pat {
PatStruct(pth_, fs, etc)
}
PatTup(ref elts) => PatTup(elts.iter().map(|x| folder.fold_pat(*x)).collect()),
PatUniq(inner) => PatUniq(folder.fold_pat(inner)),
PatBox(inner) => PatBox(folder.fold_pat(inner)),
PatRegion(inner) => PatRegion(folder.fold_pat(inner)),
PatRange(e1, e2) => {
PatRange(folder.fold_expr(e1), folder.fold_expr(e2))
Expand Down
6 changes: 3 additions & 3 deletions src/libsyntax/parse/parser.rs
Expand Up @@ -39,7 +39,7 @@ use ast::{MutImmutable, MutMutable, Mac_, MacInvocTT, Matcher, MatchNonterminal}
use ast::{MatchSeq, MatchTok, Method, MutTy, BiMul, Mutability};
use ast::{NamedField, UnNeg, NoReturn, UnNot, P, Pat, PatEnum};
use ast::{PatIdent, PatLit, PatRange, PatRegion, PatStruct};
use ast::{PatTup, PatUniq, PatWild, PatWildMulti};
use ast::{PatTup, PatBox, PatWild, PatWildMulti};
use ast::{BiRem, Required};
use ast::{RetStyle, Return, BiShl, BiShr, Stmt, StmtDecl};
use ast::{Sized, DynSize, StaticSize};
Expand Down Expand Up @@ -2784,7 +2784,7 @@ impl<'a> Parser<'a> {
// parse ~pat
self.bump();
let sub = self.parse_pat();
pat = PatUniq(sub);
pat = PatBox(sub);
hi = self.last_span.hi;
self.obsolete(self.last_span, ObsoleteOwnedPattern);
return @ast::Pat {
Expand Down Expand Up @@ -2888,7 +2888,7 @@ impl<'a> Parser<'a> {
// FIXME(#13910): Rename to `PatBox` and extend to full DST
// support.
let sub = self.parse_pat();
pat = PatUniq(sub);
pat = PatBox(sub);
hi = self.last_span.hi;
return @ast::Pat {
id: ast::DUMMY_NODE_ID,
Expand Down
2 changes: 1 addition & 1 deletion src/libsyntax/print/pprust.rs
Expand Up @@ -1721,7 +1721,7 @@ impl<'a> State<'a> {
}
try!(self.pclose());
}
ast::PatUniq(inner) => {
ast::PatBox(inner) => {
try!(word(&mut self.s, "box "));
try!(self.print_pat(inner));
}
Expand Down
2 changes: 1 addition & 1 deletion src/libsyntax/visit.rs
Expand Up @@ -429,7 +429,7 @@ pub fn walk_pat<E: Clone, V: Visitor<E>>(visitor: &mut V, pattern: &Pat, env: E)
visitor.visit_pat(*tuple_element, env.clone())
}
}
PatUniq(subpattern) |
PatBox(subpattern) |
PatRegion(subpattern) => {
visitor.visit_pat(subpattern, env)
}
Expand Down

9 comments on commit 4e3db5e

@bors
Copy link
Contributor

@bors bors commented on 4e3db5e May 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 4e3db5e May 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging ahmedcharles/rust/patbox = 4e3db5e into auto

@bors
Copy link
Contributor

@bors bors commented on 4e3db5e May 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahmedcharles/rust/patbox = 4e3db5e merged ok, testing candidate = 0e1a8c10

@bors
Copy link
Contributor

@bors bors commented on 4e3db5e May 29, 2014

@bors
Copy link
Contributor

@bors bors commented on 4e3db5e May 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 4e3db5e May 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging ahmedcharles/rust/patbox = 4e3db5e into auto

@bors
Copy link
Contributor

@bors bors commented on 4e3db5e May 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahmedcharles/rust/patbox = 4e3db5e merged ok, testing candidate = 729ee20

@bors
Copy link
Contributor

@bors bors commented on 4e3db5e May 29, 2014

@bors
Copy link
Contributor

@bors bors commented on 4e3db5e May 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 729ee20

Please sign in to comment.