Skip to content

Commit

Permalink
Updating tests to remove all "undeclared lifetime" errors (since thos…
Browse files Browse the repository at this point in the history
…e should no longer occur)
  • Loading branch information
sunjay committed Dec 13, 2017
1 parent 8cfaf1b commit 4f90eac
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 33 deletions.
Expand Up @@ -10,7 +10,8 @@

#![feature(generic_associated_types)]

//FIXME(#44265): "undeclared lifetime" errors will be addressed in a follow-up PR
//FIXME(#44265): "lifetime parameters are not allowed on this type" errors will be addressed in a
//follow-up PR

trait Foo {
type Bar<'a, 'b>;
Expand All @@ -22,8 +23,7 @@ trait Baz {

impl<T> Baz for T where T: Foo {
type Quux<'a> = <T as Foo>::Bar<'a, 'static>;
//~^ ERROR undeclared lifetime
//~| ERROR lifetime parameters are not allowed on this type [E0110]
//~^ ERROR lifetime parameters are not allowed on this type [E0110]
}

fn main() {}
@@ -1,14 +1,8 @@
error[E0261]: use of undeclared lifetime name `'a`
--> $DIR/construct_with_other_type.rs:24:37
|
24 | type Quux<'a> = <T as Foo>::Bar<'a, 'static>;
| ^^ undeclared lifetime

error[E0110]: lifetime parameters are not allowed on this type
--> $DIR/construct_with_other_type.rs:24:37
--> $DIR/construct_with_other_type.rs:25:37
|
24 | type Quux<'a> = <T as Foo>::Bar<'a, 'static>;
25 | type Quux<'a> = <T as Foo>::Bar<'a, 'static>;
| ^^ lifetime parameter not allowed on this type

error: aborting due to 2 previous errors
error: aborting due to previous error

Expand Up @@ -13,8 +13,6 @@
// Checking the interaction with this other feature
#![feature(associated_type_defaults)]

//FIXME(#44265): "undeclared lifetime" errors will be addressed in a follow-up PR

use std::fmt::{Display, Debug};

trait Foo {
Expand All @@ -32,7 +30,6 @@ impl Foo for Bar {
type Assoc2<T> = Vec<T>;
type Assoc3<T> where T: Iterator = Vec<T>;
type WithDefault<'a, T> = &'a Iterator<T>;
//~^ ERROR undeclared lifetime
type NoGenerics = ::std::cell::Cell<i32>;
}

Expand Down
@@ -1,8 +1,2 @@
error[E0261]: use of undeclared lifetime name `'a`
--> $DIR/generic-associated-types-where.rs:34:32
|
34 | type WithDefault<'a, T> = &'a Iterator<T>;
| ^^ undeclared lifetime

error: cannot continue compilation due to previous error

6 changes: 3 additions & 3 deletions src/test/ui/rfc1598-generic-associated-types/iterable.rs
Expand Up @@ -10,13 +10,13 @@

#![feature(generic_associated_types)]

//FIXME(#44265): "undeclared lifetime" errors will be addressed in a follow-up PR
//FIXME(#44265): "lifetime parameters are not allowed on this type" errors will be addressed in a
//follow-up PR

trait Iterable {
type Item<'a>;
type Iter<'a>: Iterator<Item = Self::Item<'a>>;
//~^ ERROR undeclared lifetime
//~| ERROR lifetime parameters are not allowed on this type [E0110]
//~^ ERROR lifetime parameters are not allowed on this type [E0110]

fn iter<'a>(&'a self) -> Self::Iter<'a>;
//~^ ERROR lifetime parameters are not allowed on this type [E0110]
Expand Down
12 changes: 3 additions & 9 deletions src/test/ui/rfc1598-generic-associated-types/iterable.stderr
@@ -1,13 +1,7 @@
error[E0261]: use of undeclared lifetime name `'a`
--> $DIR/iterable.rs:17:47
|
17 | type Iter<'a>: Iterator<Item = Self::Item<'a>>;
| ^^ undeclared lifetime

error[E0110]: lifetime parameters are not allowed on this type
--> $DIR/iterable.rs:17:47
--> $DIR/iterable.rs:18:47
|
17 | type Iter<'a>: Iterator<Item = Self::Item<'a>>;
18 | type Iter<'a>: Iterator<Item = Self::Item<'a>>;
| ^^ lifetime parameter not allowed on this type

error[E0110]: lifetime parameters are not allowed on this type
Expand All @@ -16,5 +10,5 @@ error[E0110]: lifetime parameters are not allowed on this type
21 | fn iter<'a>(&'a self) -> Self::Iter<'a>;
| ^^ lifetime parameter not allowed on this type

error: aborting due to 3 previous errors
error: aborting due to 2 previous errors

0 comments on commit 4f90eac

Please sign in to comment.