Skip to content

Commit

Permalink
Fix invalid lint_node_id being put on a removed stmt
Browse files Browse the repository at this point in the history
  • Loading branch information
Urgau committed Mar 3, 2022
1 parent 2f8d1a8 commit 5164884
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 2 deletions.
4 changes: 2 additions & 2 deletions compiler/rustc_expand/src/expand.rs
Expand Up @@ -1841,7 +1841,7 @@ impl<'a, 'b> MutVisitor for InvocationCollector<'a, 'b> {
self.flat_map_node(node)
}

fn flat_map_stmt(&mut self, mut node: ast::Stmt) -> SmallVec<[ast::Stmt; 1]> {
fn flat_map_stmt(&mut self, node: ast::Stmt) -> SmallVec<[ast::Stmt; 1]> {
// FIXME: invocations in semicolon-less expressions positions are expanded as expressions,
// changing that requires some compatibility measures.
if node.is_expr() {
Expand All @@ -1863,7 +1863,7 @@ impl<'a, 'b> MutVisitor for InvocationCollector<'a, 'b> {
self.cx.current_expansion.is_trailing_mac = false;
res
}
_ => assign_id!(self, &mut node.id, || noop_flat_map_stmt(node, self)),
_ => noop_flat_map_stmt(node, self),
};
}

Expand Down
10 changes: 10 additions & 0 deletions src/test/ui/check-cfg/stmt-no-ice.rs
@@ -0,0 +1,10 @@
// This test checks that there is no ICE with this code
//
// check-pass
// compile-flags:--check-cfg=names() -Z unstable-options

fn main() {
#[cfg(crossbeam_loom)]
//~^ WARNING unexpected `cfg` condition name
{}
}
10 changes: 10 additions & 0 deletions src/test/ui/check-cfg/stmt-no-ice.stderr
@@ -0,0 +1,10 @@
warning: unexpected `cfg` condition name
--> $DIR/stmt-no-ice.rs:7:11
|
LL | #[cfg(crossbeam_loom)]
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unexpected_cfgs)]` on by default

warning: 1 warning emitted

0 comments on commit 5164884

Please sign in to comment.