Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
std::trie: Fix find_mut for non-present keys
Make TrieMap/TrieSet's find_mut check the key for external nodes. Without this find_mut sometimes returns a reference to another key when querying for a non-present key.
- Loading branch information
525878f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from thestinger
at jix@525878f
525878f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging jix/rust/fix_find_mut_in_trie = 525878f into auto
525878f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jix/rust/fix_find_mut_in_trie = 525878f merged ok, testing candidate = 305bd243
525878f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1713
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2604
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/450
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/450
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2621
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1713
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1713
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2622
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1713
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1713
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/1789
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2609
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1713
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1715
exception: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/2385
525878f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from thestinger
at jix@525878f
525878f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging jix/rust/fix_find_mut_in_trie = 525878f into auto
525878f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jix/rust/fix_find_mut_in_trie = 525878f merged ok, testing candidate = ca32743
525878f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2609
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/455
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/455
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2613
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1719
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1718
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2626
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1718
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1718
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2627
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1718
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1718
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/1794
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2614
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1718
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1720
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/2390
525878f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = ca32743