Skip to content

Commit

Permalink
Fix tests for edition 2018 compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
uHOOCCOOHu committed Jul 22, 2019
1 parent 434f83a commit 5265ab8
Show file tree
Hide file tree
Showing 8 changed files with 27 additions and 27 deletions.
18 changes: 9 additions & 9 deletions tests/ui/cognitive_complexity.rs
Expand Up @@ -313,7 +313,7 @@ fn mcarton_sees_all() {
}

#[clippy::cognitive_complexity = "0"]
fn try() -> Result<i32, &'static str> {
fn try_() -> Result<i32, &'static str> {
match 5 {
5 => Ok(5),
_ => return Err("bla"),
Expand All @@ -322,14 +322,14 @@ fn try() -> Result<i32, &'static str> {

#[clippy::cognitive_complexity = "0"]
fn try_again() -> Result<i32, &'static str> {
let _ = try!(Ok(42));
let _ = try!(Ok(43));
let _ = try!(Ok(44));
let _ = try!(Ok(45));
let _ = try!(Ok(46));
let _ = try!(Ok(47));
let _ = try!(Ok(48));
let _ = try!(Ok(49));
let _ = r#try!(Ok(42));
let _ = r#try!(Ok(43));
let _ = r#try!(Ok(44));
let _ = r#try!(Ok(45));
let _ = r#try!(Ok(46));
let _ = r#try!(Ok(47));
let _ = r#try!(Ok(48));
let _ = r#try!(Ok(49));
match 5 {
5 => Ok(5),
_ => return Err("bla"),
Expand Down
8 changes: 4 additions & 4 deletions tests/ui/cognitive_complexity.stderr
Expand Up @@ -216,7 +216,7 @@ LL | | }
error: the function has a cognitive complexity of 1
--> $DIR/cognitive_complexity.rs:316:1
|
LL | / fn try() -> Result<i32, &'static str> {
LL | / fn try_() -> Result<i32, &'static str> {
LL | | match 5 {
LL | | 5 => Ok(5),
LL | | _ => return Err("bla"),
Expand All @@ -230,9 +230,9 @@ error: the function has a cognitive complexity of 1
--> $DIR/cognitive_complexity.rs:324:1
|
LL | / fn try_again() -> Result<i32, &'static str> {
LL | | let _ = try!(Ok(42));
LL | | let _ = try!(Ok(43));
LL | | let _ = try!(Ok(44));
LL | | let _ = r#try!(Ok(42));
LL | | let _ = r#try!(Ok(43));
LL | | let _ = r#try!(Ok(44));
... |
LL | | }
LL | | }
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/dlist.rs
Expand Up @@ -7,7 +7,7 @@ use alloc::collections::linked_list::LinkedList;

trait Foo {
type Baz = LinkedList<u8>;
fn foo(LinkedList<u8>);
fn foo(_: LinkedList<u8>);
const BAR: Option<LinkedList<u8>>;
}

Expand Down
6 changes: 3 additions & 3 deletions tests/ui/dlist.stderr
Expand Up @@ -8,10 +8,10 @@ LL | type Baz = LinkedList<u8>;
= help: a VecDeque might work

error: I see you're using a LinkedList! Perhaps you meant some other data structure?
--> $DIR/dlist.rs:10:12
--> $DIR/dlist.rs:10:15
|
LL | fn foo(LinkedList<u8>);
| ^^^^^^^^^^^^^^
LL | fn foo(_: LinkedList<u8>);
| ^^^^^^^^^^^^^^
|
= help: a VecDeque might work

Expand Down
4 changes: 2 additions & 2 deletions tests/ui/if_same_then_else.rs
Expand Up @@ -215,10 +215,10 @@ fn if_same_then_else() -> Result<&'static str, ()> {
};

if true {
try!(Ok("foo"));
r#try!(Ok("foo"));
} else {
//~ ERROR same body as `if` block
try!(Ok("foo"));
r#try!(Ok("foo"));
}

if true {
Expand Down
4 changes: 2 additions & 2 deletions tests/ui/if_same_then_else.stderr
Expand Up @@ -197,7 +197,7 @@ error: this `if` has identical blocks
LL | } else {
| ____________^
LL | | //~ ERROR same body as `if` block
LL | | try!(Ok("foo"));
LL | | r#try!(Ok("foo"));
LL | | }
| |_____^
|
Expand All @@ -206,7 +206,7 @@ note: same as this
|
LL | if true {
| _____________^
LL | | try!(Ok("foo"));
LL | | r#try!(Ok("foo"));
LL | | } else {
| |_____^

Expand Down
4 changes: 2 additions & 2 deletions tests/ui/unused_io_amount.rs
Expand Up @@ -4,9 +4,9 @@
use std::io;

fn try_macro<T: io::Read + io::Write>(s: &mut T) -> io::Result<()> {
try!(s.write(b"test"));
r#try!(s.write(b"test"));
let mut buf = [0u8; 4];
try!(s.read(&mut buf));
r#try!(s.read(&mut buf));
Ok(())
}

Expand Down
8 changes: 4 additions & 4 deletions tests/ui/unused_io_amount.stderr
@@ -1,17 +1,17 @@
error: handle written amount returned or use `Write::write_all` instead
--> $DIR/unused_io_amount.rs:7:5
|
LL | try!(s.write(b"test"));
| ^^^^^^^^^^^^^^^^^^^^^^^
LL | r#try!(s.write(b"test"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D clippy::unused-io-amount` implied by `-D warnings`
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

error: handle read amount returned or use `Read::read_exact` instead
--> $DIR/unused_io_amount.rs:9:5
|
LL | try!(s.read(&mut buf));
| ^^^^^^^^^^^^^^^^^^^^^^^
LL | r#try!(s.read(&mut buf));
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

Expand Down

0 comments on commit 5265ab8

Please sign in to comment.