Skip to content

Commit

Permalink
Add test for redundant_semicolon lint interaction with proc macro attrs
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanwhit committed Sep 28, 2019
1 parent d35f25c commit 66c33c0
Show file tree
Hide file tree
Showing 3 changed files with 52 additions and 0 deletions.
@@ -0,0 +1,12 @@
// force-host
// no-prefer-dynamic
#![crate_type="proc-macro"]
#![crate_name="redundant_semi_proc_macro"]
extern crate proc_macro;
use proc_macro::TokenStream;

#[proc_macro_attribute]
pub fn should_preserve_spans(_attr: TokenStream, item: TokenStream) -> TokenStream {
eprintln!("{:?}", item);
item
}
19 changes: 19 additions & 0 deletions src/test/ui/lint/redundant-semicolon/redundant-semi-proc-macro.rs
@@ -0,0 +1,19 @@
// aux-build:redundant-semi-proc-macro-def.rs

#![deny(redundant_semicolon)]
extern crate redundant_semi_proc_macro;
use redundant_semi_proc_macro::should_preserve_spans;

#[should_preserve_spans]
fn span_preservation() {
let tst = 123;; //~ ERROR unnecessary trailing semicolon
match tst {
// Redundant semicolons are parsed as empty tuple exprs
// for the lint, so ensure the lint doesn't affect
// empty tuple exprs explicitly in source.
123 => (),
_ => ()
};;; //~ ERROR unnecessary trailing semicolons
}

fn main() {}
@@ -0,0 +1,21 @@
TokenStream [Ident { ident: "fn", span: #0 bytes(197..199) }, Ident { ident: "span_preservation", span: #0 bytes(200..217) }, Group { delimiter: Parenthesis, stream: TokenStream [], span: #0 bytes(217..219) }, Group { delimiter: Brace, stream: TokenStream [Ident { ident: "let", span: #0 bytes(227..230) }, Ident { ident: "tst", span: #0 bytes(231..234) }, Punct { ch: '=', spacing: Alone, span: #0 bytes(235..236) }, Literal { lit: Lit { kind: Integer, symbol: 123, suffix: None }, span: Span { lo: BytePos(237), hi: BytePos(240), ctxt: #0 } }, Punct { ch: ';', spacing: Joint, span: #0 bytes(240..241) }, Punct { ch: ';', spacing: Alone, span: #0 bytes(241..242) }, Ident { ident: "match", span: #0 bytes(288..293) }, Ident { ident: "tst", span: #0 bytes(294..297) }, Group { delimiter: Brace, stream: TokenStream [Literal { lit: Lit { kind: Integer, symbol: 123, suffix: None }, span: Span { lo: BytePos(482), hi: BytePos(485), ctxt: #0 } }, Punct { ch: '=', spacing: Joint, span: #0 bytes(486..488) }, Punct { ch: '>', spacing: Alone, span: #0 bytes(486..488) }, Group { delimiter: Parenthesis, stream: TokenStream [], span: #0 bytes(489..491) }, Punct { ch: ',', spacing: Alone, span: #0 bytes(491..492) }, Ident { ident: "_", span: #0 bytes(501..502) }, Punct { ch: '=', spacing: Joint, span: #0 bytes(503..505) }, Punct { ch: '>', spacing: Alone, span: #0 bytes(503..505) }, Group { delimiter: Parenthesis, stream: TokenStream [], span: #0 bytes(506..508) }], span: #0 bytes(298..514) }, Punct { ch: ';', spacing: Joint, span: #0 bytes(514..515) }, Punct { ch: ';', spacing: Joint, span: #0 bytes(515..516) }, Punct { ch: ';', spacing: Alone, span: #0 bytes(516..517) }], span: #0 bytes(221..561) }]
error: unnecessary trailing semicolon
--> $DIR/redundant-semi-proc-macro.rs:9:19
|
LL | let tst = 123;;
| ^ help: remove this semicolon
|
note: lint level defined here
--> $DIR/redundant-semi-proc-macro.rs:3:9
|
LL | #![deny(redundant_semicolon)]
| ^^^^^^^^^^^^^^^^^^^

error: unnecessary trailing semicolons
--> $DIR/redundant-semi-proc-macro.rs:16:7
|
LL | };;;
| ^^ help: remove these semicolons

error: aborting due to 2 previous errors

0 comments on commit 66c33c0

Please sign in to comment.