Skip to content

Commit

Permalink
Fix missing WhileLet pattern scope
Browse files Browse the repository at this point in the history
  • Loading branch information
cramertj committed Mar 3, 2017
1 parent 042728e commit 75a35ef
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/librustc_resolve/lib.rs
Expand Up @@ -2897,8 +2897,10 @@ impl<'a> Resolver<'a> {
ExprKind::WhileLet(ref pattern, ref subexpression, ref block, label) => {
self.with_resolved_label(label, expr.id, |this| {
this.visit_expr(subexpression);
this.ribs[ValueNS].push(Rib::new(NormalRibKind));
this.resolve_pattern(pattern, PatternSource::WhileLet, &mut FxHashMap());
this.visit_block(block);
this.ribs[ValueNS].pop();
});
}

Expand Down
16 changes: 16 additions & 0 deletions src/test/run-pass/issue-40235.rs
@@ -0,0 +1,16 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn foo() {}

fn main() {
while let Some(foo) = Some(1) { break }
foo();
}

0 comments on commit 75a35ef

Please sign in to comment.