Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Generally use more modern constructs (such as using `CVec::new()` as constructor and move to more method usage). Potentially controversial changes: * change `get()` to return a reference instead of cloning * remove `set()`, add `get_mut()` instead * add an `unwrap()` method that destroys the CVec without running any associated destructor
- Loading branch information
Showing
1 changed file
with
122 additions
and
104 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
870fb7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/Blei/rust/commit/870fb7d75c3f7b0c18ae7402c387a272866c61a1
870fb7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging Blei/rust/fix_c_vec = 870fb7d into auto
870fb7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blei/rust/fix_c_vec = 870fb7d merged ok, testing candidate = c77ab91d
870fb7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2755
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/600
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/600
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2759
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1864
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2771
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1863
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1864
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2773
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1863
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2760
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1864
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1866
exception: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/2535
870fb7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/Blei/rust/commit/870fb7d75c3f7b0c18ae7402c387a272866c61a1
870fb7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging Blei/rust/fix_c_vec = 870fb7d into auto
870fb7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blei/rust/fix_c_vec = 870fb7d merged ok, testing candidate = 0e66baf
870fb7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2758
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/603
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/603
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2762
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1868
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1867
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2774
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1866
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1867
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2776
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1866
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1866
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/1942
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2763
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1867
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1869
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/2538
870fb7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 0e66baf