Skip to content

Commit

Permalink
Ignore PhantomData when checking CoerceUnsized implementations
Browse files Browse the repository at this point in the history
  • Loading branch information
ebfull committed Sep 15, 2015
1 parent b1c9616 commit b096403
Show file tree
Hide file tree
Showing 5 changed files with 82 additions and 2 deletions.
8 changes: 8 additions & 0 deletions src/librustc/middle/ty/sty.rs
Expand Up @@ -899,6 +899,14 @@ impl<'tcx> TyS<'tcx> {
}
}

pub fn is_phantom_data(&self) -> bool {
if let TyStruct(def, _) = self.sty {
def.is_phantom_data()
} else {
false
}
}

pub fn is_bool(&self) -> bool { self.sty == TyBool }

pub fn is_param(&self, space: subst::ParamSpace, index: u32) -> bool {
Expand Down
2 changes: 1 addition & 1 deletion src/librustc_trans/trans/expr.rs
Expand Up @@ -533,7 +533,7 @@ fn coerce_unsized<'blk, 'tcx>(bcx: Block<'blk, 'tcx>,
Rvalue::new(ByRef)));
} else {
// Otherwise, simply copy the data from the source.
assert_eq!(src_ty, target_ty);
assert!(src_ty.is_phantom_data() || src_ty == target_ty);
memcpy_ty(bcx, ll_target, ll_source, src_ty);
}
}
Expand Down
9 changes: 8 additions & 1 deletion src/librustc_typeck/coherence/mod.rs
Expand Up @@ -480,9 +480,16 @@ impl<'a, 'tcx> CoherenceChecker<'a, 'tcx> {
let fields = &def_a.struct_variant().fields;
let diff_fields = fields.iter().enumerate().filter_map(|(i, f)| {
let (a, b) = (f.ty(tcx, substs_a), f.ty(tcx, substs_b));
if infcx.sub_types(false, origin, b, a).is_ok() {

if f.unsubst_ty().is_phantom_data() {
// Ignore PhantomData fields
None
} else if infcx.sub_types(false, origin, b, a).is_ok() {
// Ignore fields that aren't significantly changed
None
} else {
// Collect up all fields that were significantly changed
// i.e. those that contain T in coerce_unsized T -> U
Some((i, a, b))
}
}).collect::<Vec<_>>();
Expand Down
34 changes: 34 additions & 0 deletions src/test/compile-fail/issue-26905.rs
@@ -0,0 +1,34 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![feature(unsize, coerce_unsized)]

// Verfies that non-PhantomData ZSTs still cause coercions to fail.
// They might have additional semantics that we don't want to bulldoze.

use std::marker::{Unsize, PhantomData};
use std::ops::CoerceUnsized;

struct NotPhantomData<T: ?Sized>(PhantomData<T>);

struct MyRc<T: ?Sized> {
_ptr: *const T,
_boo: NotPhantomData<T>,
}

impl<T: ?Sized + Unsize<U>, U: ?Sized> CoerceUnsized<MyRc<U>> for MyRc<T>{ } //~ERROR

fn main() {
let data = [1, 2, 3];
let iter = data.iter();
let x = MyRc { _ptr: &iter, _boo: NotPhantomData(PhantomData) };
let _y: MyRc<Iterator<Item=&u32>> = x;
}

31 changes: 31 additions & 0 deletions src/test/run-pass/issue-26905.rs
@@ -0,0 +1,31 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![feature(unsize, coerce_unsized)]

// Verfies that PhantomData is ignored for DST coercions

use std::marker::{Unsize, PhantomData};
use std::ops::CoerceUnsized;

struct MyRc<T: ?Sized> {
_ptr: *const T,
_boo: PhantomData<T>,
}

impl<T: ?Sized + Unsize<U>, U: ?Sized> CoerceUnsized<MyRc<U>> for MyRc<T>{ }

fn main() {
let data = [1, 2, 3];
let iter = data.iter();
let x = MyRc { _ptr: &iter, _boo: PhantomData };
let _y: MyRc<Iterator<Item=&u32>> = x;
}

0 comments on commit b096403

Please sign in to comment.