Suggest dereferencing boolean reference when used in 'if' or 'while'

Change-Id: I0c5c4d767be2647e6f017ae7bf83558c56dbca97
rust-lang · Oct 6, 2019 · bbb69d1 · bbb69d1
1 parent 8a164ac
commit bbb69d1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 40 deletions.
diff --git a/src/test/ui/if/if-no-match-bindings.stderr b/src/test/ui/if/if-no-match-bindings.stderr
@@ -73,7 +73,7 @@ LL |     while b_mut_ref() {}
 error[E0308]: mismatched types
   --> $DIR/if-no-match-bindings.rs:26:11
    |
-26 |     while &true {}
+LL |     while &true {}
    |           ^^^^^
    |           |
    |           expected bool, found &bool
@@ -85,7 +85,7 @@ error[E0308]: mismatched types
 error[E0308]: mismatched types
   --> $DIR/if-no-match-bindings.rs:27:11
    |
-27 |     while &mut true {}
+LL |     while &mut true {}
    |           ^^^^^^^^^
    |           |
    |           expected bool, found &mut bool

diff --git a/src/test/ui/rfc-2497-if-let-chains/disallowed-positions.stderr b/src/test/ui/rfc-2497-if-let-chains/disallowed-positions.stderr
@@ -513,44 +513,6 @@ warning: the feature `let_chains` is incomplete and may cause the compiler to cr
 LL | #![feature(let_chains)] // Avoid inflating `.stderr` with overzealous gates in this test.
    |            ^^^^^^^^^^
 
-warning: unnecessary parentheses around `if` condition
-  --> $DIR/disallowed-positions.rs:51:8
-   |
-LL |     if (true || let 0 = 0) {}
-   |        ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
-   |
-   = note: `#[warn(unused_parens)]` on by default
-
-warning: unnecessary parentheses around `while` condition
-  --> $DIR/disallowed-positions.rs:115:11
-   |
-LL |     while (true || let 0 = 0) {}
-   |           ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
-
-wrning: unnecessary parentheses around `let` head expression
-  --> $DIR/disallowed-positions.rs:160:41
-   |
-LL |     if let Range { start: _, end: _ } = (true..true || false) { }
-   |                                         ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
-
-warning: unnecessary parentheses around `let` head expression
-  --> $DIR/disallowed-positions.rs:162:41
-   |
-LL |     if let Range { start: _, end: _ } = (true..true && false) { }
-   |                                         ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
-
-warning: unnecessary parentheses around `let` head expression
-  --> $DIR/disallowed-positions.rs:164:44
-   |
-LL |     while let Range { start: _, end: _ } = (true..true || false) { }
-   |                                            ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
-
-warning: unnecessary parentheses around `let` head expression
-  --> $DIR/disallowed-positions.rs:166:44
-   |
-LL |     while let Range { start: _, end: _ } = (true..true && false) { }
-   |                                            ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
-
 error[E0308]: mismatched types
   --> $DIR/disallowed-positions.rs:32:8
    |