Skip to content

Commit

Permalink
Get rid of no-longer-needed #[doc(hidden)] attributes.
Browse files Browse the repository at this point in the history
There were several old `#[doc(hidden)]` attributes in libstd and
libextra, left over from when rustdoc didn't hide private
definitions, tagged with `FIXME #3538`.

Since #3538 is now closed, I removed the `#[doc(hidden)]` attributes
as well as the FIXMEs, but I left `#[doc(hidden)]` in
libstd/task/spawn.rs and libstd/task/rt.rs since those two are
apparently `pub`, as well as in libextra/std.rc since std/extra is
`pub`.
  • Loading branch information
lkuper committed May 27, 2013
1 parent 3941f78 commit beec6e4
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 13 deletions.
4 changes: 2 additions & 2 deletions src/libextra/std.rc
Expand Up @@ -123,7 +123,7 @@ pub mod serialize;
// A curious inner-module that's not exported that contains the binding
// 'extra' so that macro-expanded references to std::serialize and such
// can be resolved within libextra.
#[doc(hidden)] // FIXME #3538
#[doc(hidden)]
pub mod std {
pub use serialize;
pub use test;
Expand All @@ -134,7 +134,7 @@ pub mod std {
pub use core::cmp;
pub use core::sys;
}
#[doc(hidden)] // FIXME #3538
#[doc(hidden)]
pub mod extra {
pub use serialize;
pub use test;
Expand Down
2 changes: 0 additions & 2 deletions src/libstd/num/cmath.rs
Expand Up @@ -8,8 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#[doc(hidden)]; // FIXME #3538

// function names are almost identical to C's libmath, a few have been
// renamed, grep for "rename:"

Expand Down
2 changes: 0 additions & 2 deletions src/libstd/stackwalk.rs
Expand Up @@ -8,8 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#[doc(hidden)]; // FIXME #3538

use cast::transmute;
use unstable::intrinsics;

Expand Down
2 changes: 0 additions & 2 deletions src/libstd/task/local_data_priv.rs
Expand Up @@ -8,8 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#[doc(hidden)]; // FIXME #3538

use cast;
use cmp::Eq;
use libc;
Expand Down
1 change: 0 additions & 1 deletion src/libstd/task/mod.rs
Expand Up @@ -195,7 +195,6 @@ pub fn task() -> TaskBuilder {
}
}

#[doc(hidden)] // FIXME #3538
priv impl TaskBuilder {
fn consume(&mut self) -> TaskBuilder {
if self.consumed {
Expand Down
2 changes: 1 addition & 1 deletion src/libstd/task/rt.rs
Expand Up @@ -14,7 +14,7 @@ The task interface to the runtime
*/

#[doc(hidden)]; // FIXME #3538
#[doc(hidden)];

use libc;

Expand Down
2 changes: 1 addition & 1 deletion src/libstd/task/spawn.rs
Expand Up @@ -70,7 +70,7 @@
*
****************************************************************************/

#[doc(hidden)]; // FIXME #3538
#[doc(hidden)];

use cast::transmute;
use cast;
Expand Down
2 changes: 0 additions & 2 deletions src/libstd/unicode.rs
Expand Up @@ -8,8 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#[doc(hidden)]; // FIXME #3538

// The following code was generated by "src/etc/unicode.py"

pub mod general_category {
Expand Down

5 comments on commit beec6e4

@bors
Copy link
Contributor

@bors bors commented on beec6e4 May 27, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from thestinger
at lkuper@beec6e4

@bors
Copy link
Contributor

@bors bors commented on beec6e4 May 27, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging lkuper/rust/3538 = beec6e4 into auto

@bors
Copy link
Contributor

@bors bors commented on beec6e4 May 27, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lkuper/rust/3538 = beec6e4 merged ok, testing candidate = d98cc99

@bors
Copy link
Contributor

@bors bors commented on beec6e4 May 27, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on beec6e4 May 27, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding incoming to auto = d98cc99

Please sign in to comment.