Skip to content

Commit

Permalink
Fix #15896
Browse files Browse the repository at this point in the history
Fix ICE when there's an incorrect enum variant constructor in match arm.

Closes #15896.
  • Loading branch information
edwardw committed Jul 24, 2014
1 parent 482c776 commit c3f4c6d
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/librustc/middle/typeck/check/_match.rs
Expand Up @@ -390,7 +390,9 @@ pub fn check_struct_like_enum_variant_pat(pcx: &pat_ctxt,
check_struct_pat_fields(pcx, span, fields, class_fields,
variant_id, substitutions, etc);
}
Some(&def::DefStruct(..)) | Some(&def::DefVariant(..)) => {
Some(&def::DefStruct(..)) |
Some(&def::DefVariant(..)) |
Some(&def::DefTy(..)) => {
let name = pprust::path_to_string(path);
span_err!(tcx.sess, span, E0028,
"mismatched types: expected `{}` but found `{}`",
Expand Down
24 changes: 24 additions & 0 deletions src/test/compile-fail/issue-15896.rs
@@ -0,0 +1,24 @@
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Regression test for #15896. It used to ICE rustc.

fn main() {
enum R { REB(()) }
struct Tau { t: uint }
enum E { B(R, Tau) }

let e = B(REB(()), Tau { t: 3 });
let u = match e {
B(
Tau{t: x}, //~ ERROR mismatched types
_) => x,
};
}

5 comments on commit c3f4c6d

@bors
Copy link
Contributor

@bors bors commented on c3f4c6d Jul 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at edwardw@c3f4c6d

@bors
Copy link
Contributor

@bors bors commented on c3f4c6d Jul 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging edwardw/rust/issue-15896 = c3f4c6d into auto

@bors
Copy link
Contributor

@bors bors commented on c3f4c6d Jul 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edwardw/rust/issue-15896 = c3f4c6d merged ok, testing candidate = a455345

@bors
Copy link
Contributor

@bors bors commented on c3f4c6d Jul 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = a455345

Please sign in to comment.