Skip to content

Commit

Permalink
rustc_driver: have TrimmedDefPaths::GoodPath only for rustc
Browse files Browse the repository at this point in the history
`run_compiler` is used by clippy and other tools, which should not have
the trimmed paths feature enabled by default, until we see it works well
for them.

Would also be nice to rename `TimePassesCallbacks` however it's a
submodule change.
  • Loading branch information
da-x committed Sep 3, 2020
1 parent 07e7823 commit c5a6131
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions compiler/rustc_driver/src/lib.rs
Expand Up @@ -127,6 +127,7 @@ impl Callbacks for TimePassesCallbacks {
// time because it will mess up the --prints output. See #64339.
self.time_passes = config.opts.prints.is_empty()
&& (config.opts.debugging_opts.time_passes || config.opts.debugging_opts.time);
config.opts.trimmed_def_paths = TrimmedDefPaths::GoodPath;
}
}

Expand Down Expand Up @@ -159,10 +160,7 @@ pub fn run_compiler(
None => return Ok(()),
};

let sopts = config::Options {
trimmed_def_paths: TrimmedDefPaths::GoodPath,
..config::build_session_options(&matches)
};
let sopts = config::build_session_options(&matches);
let cfg = interface::parse_cfgspecs(matches.opt_strs("cfg"));

let mut dummy_config = |sopts, cfg, diagnostic_output| {
Expand Down

0 comments on commit c5a6131

Please sign in to comment.