Replace span suggestion with multipart

rust-lang · Jan 28, 2022 · c734c32 · c734c32
1 parent 4738ce4
commit c734c32
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 14 deletions.
diff --git a/compiler/rustc_infer/src/infer/error_reporting/mod.rs b/compiler/rustc_infer/src/infer/error_reporting/mod.rs
@@ -2045,18 +2045,14 @@ impl<'a, 'tcx> InferCtxt<'a, 'tcx> {
                         // parentheses around it, perhaps the user meant to write `(expr,)` to
                         // build a tuple (issue #86100)
                         (ty::Tuple(_), _) if expected.tuple_fields().count() == 1 => {
-                            if let Ok(code) = self.tcx.sess().source_map().span_to_snippet(span) {
-                                let code_stripped = code
-                                    .strip_prefix('(')
-                                    .and_then(|s| s.strip_suffix(')'))
-                                    .unwrap_or(&code);
-                                err.span_suggestion(
-                                    span,
-                                    "use a trailing comma to create a tuple with one element",
-                                    format!("({},)", code_stripped),
-                                    Applicability::MaybeIncorrect,
-                                );
-                            }
+                            err.multipart_suggestion(
+                                "use a trailing comma to create a tuple with one element",
+                                vec![
+                                    (span.shrink_to_lo(), "(".into()),
+                                    (span.shrink_to_hi(), ",)".into()),
+                                ],
+                                Applicability::MaybeIncorrect,
+                            );
                         }
                         // If a character was expected and the found expression is a string literal
                         // containing a single character, perhaps the user meant to write `'c'` to

diff --git a/src/test/ui/consts/const-tup-index-span.stderr b/src/test/ui/consts/const-tup-index-span.stderr
@@ -9,7 +9,7 @@ LL | const TUP: (usize,) = 5usize << 64;
 help: use a trailing comma to create a tuple with one element
    |
 LL | const TUP: (usize,) = (5usize << 64,);
-   |                       ~~~~~~~~~~~~~~~
+   |                       +            ++
 
 error: aborting due to previous error
 

diff --git a/src/test/ui/typeck/issue-84768.stderr b/src/test/ui/typeck/issue-84768.stderr
@@ -15,7 +15,7 @@ LL |     <F as FnOnce(&mut u8)>::call_once(f, 1)
 help: use a trailing comma to create a tuple with one element
    |
 LL |     <F as FnOnce(&mut u8)>::call_once(f, (1,))
-   |                                          ~~~~
+   |                                          + ++
 
 error: aborting due to 2 previous errors