Fix reversed suggestion on postfix

rust-lang · Dec 25, 2021 · c8f016f · c8f016f
1 parent 8ed723b
commit c8f016f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/clippy_lints/src/enum_variants.rs b/clippy_lints/src/enum_variants.rs
@@ -185,7 +185,10 @@ fn check_variant(cx: &LateContext<'_>, threshold: u64, def: &EnumDef<'_>, item_n
     let (what, value) = match (pre.is_empty(), post.is_empty()) {
         (true, true) => return,
         (false, _) => ("pre", pre.join("")),
-        (true, false) => ("post", post.join("")),
+        (true, false) => {
+            post.reverse();
+            ("post", post.join(""))
+        },
     };
     span_lint_and_help(
         cx,

diff --git a/tests/ui/enum_variants.stderr b/tests/ui/enum_variants.stderr
@@ -96,7 +96,7 @@ LL | | }
    |
    = help: remove the prefixes and use full paths to the variants instead of glob imports
 
-error: all variants have the same postfix: `DataI`
+error: all variants have the same postfix: `IData`
   --> $DIR/enum_variants.rs:136:1
    |
 LL | / enum IDataRequest {
@@ -108,7 +108,7 @@ LL | | }
    |
    = help: remove the postfixes and use full paths to the variants instead of glob imports
 
-error: all variants have the same postfix: `DataIH`
+error: all variants have the same postfix: `HIData`
   --> $DIR/enum_variants.rs:142:1
    |
 LL | / enum HIDataRequest {