Use closure body span (fixes #1405)

rust-lang · Jan 15, 2017 · cdfe002 · cdfe002
1 parent 57e056d
commit cdfe002
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/clippy_lints/src/returns.rs b/clippy_lints/src/returns.rs
@@ -138,7 +138,7 @@ impl EarlyLintPass for ReturnPass {
         match kind {
             FnKind::ItemFn(.., block) |
             FnKind::Method(.., block) => self.check_block_return(cx, block),
-            FnKind::Closure(body) => self.check_final_expr(cx, body, None),
+            FnKind::Closure(body) => self.check_final_expr(cx, body, Some(body.span)),
         }
     }
 

diff --git a/tests/compile-fail/needless_return.rs b/tests/compile-fail/needless_return.rs
@@ -58,6 +58,10 @@ fn test_closure() {
         //~| HELP remove `return` as shown
         //~| SUGGESTION true
     };
+    let _ = || return true;
+    //~^ ERROR unneeded return statement
+    //~| HELP remove `return` as shown
+    //~| SUGGESTION true
 }
 
 fn main() {